Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds quick_discouraged_pending_test opt-in rule #1910

Closed
wants to merge 1 commit into from
Closed

Adds quick_discouraged_pending_test opt-in rule #1910

wants to merge 1 commit into from

Conversation

ornithocoder
Copy link
Contributor

Implements #1909.

@SwiftLintBot
Copy link

3 Warnings
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickTests/FunctionalTests/PendingTests.swift:17:9: warning: Quick Discouraged Pending Test Violation: Discouraged pending test. This test won't run while it's marked as pending. (quick_discouraged_pending_test)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickTests/FunctionalTests/PendingTests.swift:24:13: warning: Quick Discouraged Pending Test Violation: Discouraged pending test. This test won't run while it's marked as pending. (quick_discouraged_pending_test)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickTests/FunctionalTests/PendingTests.swift:29:13: warning: Quick Discouraged Pending Test Violation: Discouraged pending test. This test won't run while it's marked as pending. (quick_discouraged_pending_test)
12 Messages
📖 Linting Aerial with this PR took 0.47s vs 0.39s on master (20% slower)
📖 Linting Alamofire with this PR took 3.2s vs 2.96s on master (8% slower)
📖 Linting Firefox with this PR took 12.84s vs 12.34s on master (4% slower)
📖 Linting Kickstarter with this PR took 20.24s vs 19.46s on master (4% slower)
📖 Linting Moya with this PR took 1.47s vs 1.43s on master (2% slower)
📖 Linting Nimble with this PR took 1.86s vs 1.81s on master (2% slower)
📖 Linting Quick with this PR took 0.54s vs 0.54s on master (0% slower)
📖 Linting Realm with this PR took 3.23s vs 3.18s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.05s vs 1.04s on master (0% slower)
📖 Linting Sourcery with this PR took 4.28s vs 4.29s on master (0% faster)
📖 Linting Swift with this PR took 13.55s vs 13.34s on master (1% slower)
📖 Linting WordPress with this PR took 11.96s vs 11.79s on master (1% slower)

Generated by 🚫 Danger

marcelofabri
marcelofabri reviewed Oct 17, 2017
View reviewed changes
Source/SwiftLintFramework/Rules/QuickDiscouragedPendingTestRule.swift
case pending
case xdescribe
case xcontext
case xit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably xitBehavesLike should be here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Quick's SDL.swift doesn't have xitBehavesLike. It's defined as a #define in QCKSDL.h. I'll add it.

@ornithocoder
Copy link
Contributor Author

That's weird. GitHub didn't update the PR with the commits from my branch.

@ornithocoder
Copy link
Contributor Author

I guess I'll have to close this one and open another PR. GitHub didn't pick my last two commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelofabri marcelofabri marcelofabri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ornithocoder @SwiftLintBot @marcelofabri