Adds opt-in discouraged_optional_boolean rule #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
==========================================
+ Coverage 89.65% 89.67% +0.01%
==========================================
Files 254 256 +2
Lines 14843 14861 +18
Branches 965 968 +3
==========================================
+ Hits 13308 13327 +19
+ Misses 1516 1515 -1
Partials 19 19
Continue to review full report at Codecov.
|
ornithocoder
changed the title
| @@ -74,6 +74,10 @@ class RulesTests: XCTestCase { | |||
| verifyRule(DiscouragedObjectLiteralRule.description) | |||
| } | |||
|
|
|||
| func testDiscouragedOptionalBoolean() { | |||
There was a problem hiding this comment.
You need to run Sourcery to update the tests list to be run on Linux
There was a problem hiding this comment.
Done :-) Sorry about that, @marcelofabri. Thanks.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2011.