Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identical_operands opt-in rule #2372

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Add identical_operands opt-in rule #2372

merged 2 commits into from
Sep 10, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1371.

This rule was made opt-in because it's kind of slow to run 🐢

@SwiftLintBot
Copy link

11 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:2327:46: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/ServiceTests.swift:18:19: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/ServiceTests.swift:19:19: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/ServiceTests.swift:20:19: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/ServiceTests.swift:21:19: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift:2659:7: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift:2665:7: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift:2670:16: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift:2675:16: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
⚠️ This PR introduced a violation in Swift: /Users/distiller/project/osscheck/Swift/stdlib/public/core/KeyPath.swift:461:10: warning: Identical Operands Violation: Comparing two identical operands is likely a mistake. (identical_operands)
12 Messages
📖 Linting Aerial with this PR took 0.44s vs 0.38s on master (15% slower)
📖 Linting Alamofire with this PR took 3.78s vs 3.22s on master (17% slower)
📖 Linting Firefox with this PR took 14.82s vs 12.37s on master (19% slower)
📖 Linting Kickstarter with this PR took 20.11s vs 18.45s on master (8% slower)
📖 Linting Moya with this PR took 2.02s vs 2.28s on master (11% faster)
📖 Linting Nimble with this PR took 1.8s vs 2.15s on master (16% faster)
📖 Linting Quick with this PR took 0.54s vs 0.58s on master (6% faster)
📖 Linting Realm with this PR took 3.37s vs 3.39s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.09s vs 1.11s on master (1% faster)
📖 Linting Sourcery with this PR took 4.69s vs 4.9s on master (4% faster)
📖 Linting Swift with this PR took 28.48s vs 29.87s on master (4% faster)
📖 Linting WordPress with this PR took 18.75s vs 18.07s on master (3% slower)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit c9f315a into realm:master Sep 10, 2018
@marcelofabri marcelofabri deleted the identical_operands branch September 10, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants