Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnusedPrivateDeclarationRule #2385

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Add UnusedPrivateDeclarationRule #2385

merged 2 commits into from
Sep 6, 2018

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Sep 3, 2018

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 3, 2018

12 Messages
📖 Linting Aerial with this PR took 0.45s vs 0.43s on master (4% slower)
📖 Linting Alamofire with this PR took 3.56s vs 3.52s on master (1% slower)
📖 Linting Firefox with this PR took 14.27s vs 13.3s on master (7% slower)
📖 Linting Kickstarter with this PR took 21.9s vs 18.78s on master (16% slower)
📖 Linting Moya with this PR took 2.39s vs 2.1s on master (13% slower)
📖 Linting Nimble with this PR took 2.09s vs 2.05s on master (1% slower)
📖 Linting Quick with this PR took 0.64s vs 0.6s on master (6% slower)
📖 Linting Realm with this PR took 3.83s vs 3.48s on master (10% slower)
📖 Linting SourceKitten with this PR took 1.26s vs 1.3s on master (3% faster)
📖 Linting Sourcery with this PR took 5.29s vs 4.96s on master (6% slower)
📖 Linting Swift with this PR took 32.85s vs 29.94s on master (9% slower)
📖 Linting WordPress with this PR took 19.91s vs 18.31s on master (8% slower)

Generated by 🚫 Danger

@jpsim
Copy link
Collaborator Author

jpsim commented Sep 3, 2018

Seems like this rule is crashing SourceKit on the (fairly old) Xcode 10 beta version that CircleCI has. Gonna keep this open until a new Xcode 10 image is available.

@marcelofabri
Copy link
Collaborator

Does this catch using a private function in #selector? If so, what do you think about adding a test to document this?

@jpsim
Copy link
Collaborator Author

jpsim commented Sep 4, 2018

Yes, it would catch that. There are so many potential test cases to include for this rule that I just haven’t added basically any. I should.

So we can merge UnusedPrivateDeclarationRule without having to wait
for CircleCI to update its Xcode 10 version.
@jpsim jpsim merged commit 53d8a3a into master Sep 6, 2018
@jpsim jpsim deleted the unused-private-declaration branch September 6, 2018 04:59
@Jeehut Jeehut mentioned this pull request Sep 6, 2018
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
* Add UnusedPrivateDeclarationRule

* Temporarily disable UnusedPrivateDeclarationRule tests on Xcode 10

So we can merge UnusedPrivateDeclarationRule without having to wait
for CircleCI to update its Xcode 10 version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants