Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives on explicit_type_interface rule #2426

Merged
merged 4 commits into from
Nov 28, 2018

Conversation

Jeehut
Copy link
Collaborator

@Jeehut Jeehut commented Sep 28, 2018

Fixes #2425.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 28, 2018

12 Messages
📖 Linting Aerial with this PR took 2.67s vs 2.51s on master (6% slower)
📖 Linting Alamofire with this PR took 4.86s vs 4.97s on master (2% faster)
📖 Linting Firefox with this PR took 19.74s vs 17.07s on master (15% slower)
📖 Linting Kickstarter with this PR took 29.4s vs 27.63s on master (6% slower)
📖 Linting Moya with this PR took 2.6s vs 2.63s on master (1% faster)
📖 Linting Nimble with this PR took 2.69s vs 2.48s on master (8% slower)
📖 Linting Quick with this PR took 0.79s vs 0.81s on master (2% faster)
📖 Linting Realm with this PR took 4.82s vs 4.78s on master (0% slower)
📖 Linting SourceKitten with this PR took 1.91s vs 1.51s on master (26% slower)
📖 Linting Sourcery with this PR took 6.79s vs 5.7s on master (19% slower)
📖 Linting Swift with this PR took 43.79s vs 33.06s on master (32% slower)
📖 Linting WordPress with this PR took 31.36s vs 23.26s on master (34% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2426 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
+ Coverage   90.77%   90.77%   +<.01%     
==========================================
  Files         320      320              
  Lines       16182    16191       +9     
==========================================
+ Hits        14689    14698       +9     
  Misses       1493     1493
Impacted Files Coverage Δ
...rameworkTests/ExplicitTypeInterfaceRuleTests.swift 100% <100%> (ø) ⬆️
...rk/Rules/Idiomatic/ExplicitTypeInterfaceRule.swift 96.66% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf85625...4adfd9d. Read the comment docs.

@Jeehut Jeehut mentioned this pull request Nov 8, 2018
@jpsim
Copy link
Collaborator

jpsim commented Nov 27, 2018

Thanks for the PR. Could you please rebase to address the merge conflict?

@jpsim jpsim force-pushed the allow-redundancy-fix branch from 4adfd9d to ea770d0 Compare November 28, 2018 16:50
@jpsim
Copy link
Collaborator

jpsim commented Nov 28, 2018

Thanks for the PR. Could you please rebase to address the merge conflict?

I took care of this, rebased and force-pushed to your branch. Will merge when CI approves.

@jpsim jpsim merged commit 38b0114 into realm:master Nov 28, 2018
@Jeehut Jeehut deleted the allow-redundancy-fix branch February 12, 2019 11:47
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants