Update Discarded Notification Center Observer Violation false positive trigger on array append #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Mar 23, 2019
ghost
commented
- This fixes an issue where the notification center observer is appended to an array, which triggers the violation. Fixes Discarded Notification Center Observer Violation false trigger #2684.
- This fixes an issue where the notification center observer is appended to an array, which triggers the violation. Fixes #2684.
Jeehut
requested changes
Mar 26, 2019
Source/SwiftLintFramework/Rules/Lint/DiscardedNotificationCenterObserverRule.swift
Outdated
Show resolved
Hide resolved
|
Okay, I will update the PR to make it more generic. |
- Updated rule to not trigger if notification observer is passed to any function as argument (#2684)
Generated by 🚫 Danger |
Jeehut
requested changes
Mar 27, 2019
|
I have added non-triggering example for array append and passing as function call argument. I will add an example on dictionary. The triggering example is the same. |
Jeehut
approved these changes
Mar 27, 2019
|
Looks good to me now. Thank you very much! Merging. 🎉 |
|
Welcome :) |
marcelofabri
reviewed
Apr 1, 2019
| @@ -51,6 +61,11 @@ public struct DiscardedNotificationCenterObserverRule: ASTRule, ConfigurationPro | |||
| return [] | |||
| } | |||
|
|
|||
| if let lastMatch = regex("\\b[^\\(]+").matches(in: file.contents, options: [], range: range).last?.range, | |||
There was a problem hiding this comment.
won't this cause false negatives? e.g.
print(nc.addObserver(forName: .NSSystemTimeZoneDidChange, object: nil, queue: nil, using: { }))
marcelofabri
reviewed
Apr 1, 2019
| * `discarded_notification_center_observer` rule now checks if the observer is | ||
| added to any collection or passed to a function before triggering the violation. | ||
| [jsloop42](https://github.com/jsloop42) | ||
| [#2684](https://github.com/realm/SwiftLint/issues/2684) |
There was a problem hiding this comment.
we should update this to mention #1398 which is older
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.