Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unowned_variable_capture opt-in rule #2739

Merged
merged 1 commit into from
May 2, 2019

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2097

@SwiftLintBot
Copy link

101 Warnings
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Validation.swift:160:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Validation.swift:174:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Validation.swift:187:47: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Validation.swift:214:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Validation.swift:228:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Validation.swift:250:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Request.swift:857:40: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Alamofire: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Alamofire/Source/Request.swift:1039:40: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Firefox/Client/Frontend/Home/ActivityStreamPanel.swift:552:57: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController/BrowserViewController+ReaderMode.swift:173:39: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Firefox/Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift:286:41: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Firefox/Client/Frontend/Login/LoginViewController.swift:20:38: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in Firefox: /Users/vsts/agent/2.150.2/work/1/s/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1068:65: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Cells/ExpandableCell.swift:41:50: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Domains/Register/RegisterDomainDetails/ViewController/RegisterDomainDetailsViewController.swift:60:33: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/PostEditor+Publish.swift:53:73: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/PostEditor+Publish.swift:67:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/PostEditor+Publish.swift:103:29: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/Revisions/Browser/RevisionDiffsBrowserViewController.swift:236:80: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plans/PlanListViewController.swift:69:14: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plans/PlansLoadingIndicatorView.swift:184:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plans/PlansLoadingIndicatorView.swift:194:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plans/PlansLoadingIndicatorView.swift:204:28: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift:908:68: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:177:33: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:222:33: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:265:27: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:278:26: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:296:26: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:325:24: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:336:24: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:346:24: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:362:27: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:378:27: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:394:27: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:410:27: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Plugins/PluginViewModel.swift:503:25: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController+MoreActions.swift:30:73: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController+MoreActions.swift:42:61: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController+MoreActions.swift:77:37: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/QuickStartChecklistViewController.swift:104:29: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingAccountViewController.swift:198:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSpeedUpSiteSettingsViewController.swift:90:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSpeedUpSiteSettingsViewController.swift:102:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/DateAndTimeFormatSettingsViewController.swift:113:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/DateAndTimeFormatSettingsViewController.swift:146:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/DateAndTimeFormatSettingsViewController.swift:179:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:177:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:189:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:200:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:211:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:223:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:256:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:268:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackSecuritySettingsViewController.swift:279:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/JetpackConnectionViewController.swift:73:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:151:25: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:154:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:169:25: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:172:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:190:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:213:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:240:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:279:25: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:282:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:303:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:322:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:348:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:388:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:430:31: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:681:39: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:714:41: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SharingButtonsViewController.swift:738:39: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift:161:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift:178:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift:195:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift:207:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift:248:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift:255:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:1064:37: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:1182:79: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:1196:61: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:1200:73: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:1205:77: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift:1210:78: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:242:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:251:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:264:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:272:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:279:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:292:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Me/MeViewController.swift:299:19: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/People/InvitePersonViewController.swift:181:48: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/People/InvitePersonViewController.swift:198:42: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/People/InvitePersonViewController.swift:215:48: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/Utility/Spotlight/SearchManager.swift:456:29: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/Utility/CookieJar.swift:42:23: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/Utility/CookieJar.swift:107:25: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/Utility/ImmuTableViewController.swift:14:14: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/Utility/ImmuTableViewController.swift:22:14: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.150.2/work/1/s/osscheck/WordPress/WordPress/Classes/Utility/Animator.swift:61:109: warning: Unowned Variable Capture Violation: Prefer capturing references as weak to avoid potential crashes. (unowned_variable_capture)
12 Messages
📖 Linting Aerial with this PR took 3.22s vs 3.79s on master (15% faster)
📖 Linting Alamofire with this PR took 5.27s vs 5.98s on master (11% faster)
📖 Linting Firefox with this PR took 16.94s vs 17.99s on master (5% faster)
📖 Linting Kickstarter with this PR took 31.52s vs 35.48s on master (11% faster)
📖 Linting Moya with this PR took 2.92s vs 3.02s on master (3% faster)
📖 Linting Nimble with this PR took 2.59s vs 2.85s on master (9% faster)
📖 Linting Quick with this PR took 0.92s vs 0.97s on master (5% faster)
📖 Linting Realm with this PR took 3.98s vs 4.6s on master (13% faster)
📖 Linting SourceKitten with this PR took 1.53s vs 1.94s on master (21% faster)
📖 Linting Sourcery with this PR took 5.8s vs 6.47s on master (10% faster)
📖 Linting Swift with this PR took 43.97s vs 47.41s on master (7% faster)
📖 Linting WordPress with this PR took 35.27s vs 36.69s on master (3% faster)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit c33fc83 into master May 2, 2019
@marcelofabri marcelofabri deleted the marcelo/unowned_variable_capture branch May 2, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Request: unowned_captures
2 participants