Add UnusedDeclarationRule #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
keith
approved these changes
Jul 18, 2019
|
|
||
| // Classes marked as @UIApplicationMain are used by the operating system as the entry point into the app. | ||
| if let annotatedDecl = cursorInfo["key.annotated_decl"] as? String, | ||
| annotatedDecl.contains("@UIApplicationMain") { |
There was a problem hiding this comment.
should we add @objcMembers in this same spot?
There was a problem hiding this comment.
Good question. You could still have unused @objcMembers classes though.
I'm inclined to still treat those as violations until someone requests otherwise.
4 tasks
jpsim
force-pushed
the
unused-declaration-rule
branch
from
6381063 to
69bc07b
Compare
Which was causing tests to fail on Swift 4.x
jpsim
force-pushed
the
unused-declaration-rule
branch
from
e2ec411 to
9a4a8c7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
unused_declarationanalyzer rule to lint for unused declarations.By default, detects unused
fileprivate,privateandinternaldeclarations.Configure the rule with
include_public_and_open: trueto also detect unusedpublicandopendeclarations.Completely remove the
unused_private_declarationrule.This is built on the work enabling collecting rule infrastructure in #2714.