Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mark rule for triple slash Mark comments #2868

Merged
merged 6 commits into from
Sep 19, 2019

Conversation

nvanfleet
Copy link
Contributor

Add two new cases to the Mark rule to detect a Mark using three slashes.

@SwiftLintBot
Copy link

14 Warnings
⚠️ This PR introduced a violation in Moya: /Users/vsts/agent/2.155.1/work/1/s/osscheck/Moya/Sources/Moya/MoyaProvider.swift:160:1: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Reader/ReaderDetailViewController.swift:1535:1: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Reader/ReaderDetailViewController.swift:1547:1: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Tools/PromptViewController.swift:19:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Ratings/AppFeedbackPromptView.swift:14:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Ratings/AppFeedbackPromptView.swift:26:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Ratings/AppFeedbackPromptView.swift:139:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SiteIconPickerPresenter.swift:11:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SiteIconPickerPresenter.swift:19:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SiteIconPickerPresenter.swift:50:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Blog/SiteIconPickerPresenter.swift:74:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/ViewRelated/Media/Giphy/GiphyMedia.swift:96:1: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/Services/PeopleService.swift:8:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
⚠️ This PR introduced a violation in WordPress: /Users/vsts/agent/2.155.1/work/1/s/osscheck/WordPress/WordPress/Classes/Services/PeopleService.swift:12:5: warning: Mark Violation: MARK comment should be in valid format. e.g. '// MARK: …' or '// MARK: - …' (mark)
12 Messages
📖 Linting Aerial with this PR took 3.97s vs 3.52s on master (12% slower)
📖 Linting Alamofire with this PR took 7.75s vs 6.15s on master (26% slower)
📖 Linting Firefox with this PR took 19.03s vs 18.78s on master (1% slower)
📖 Linting Kickstarter with this PR took 41.81s vs 40.19s on master (4% slower)
📖 Linting Moya with this PR took 3.5s vs 3.6s on master (2% faster)
📖 Linting Nimble with this PR took 3.15s vs 3.32s on master (5% faster)
📖 Linting Quick with this PR took 1.21s vs 1.15s on master (5% slower)
📖 Linting Realm with this PR took 6.36s vs 6.5s on master (2% faster)
📖 Linting SourceKitten with this PR took 2.46s vs 2.5s on master (1% faster)
📖 Linting Sourcery with this PR took 6.5s vs 6.4s on master (1% slower)
📖 Linting Swift with this PR took 49.79s vs 50.21s on master (0% faster)
📖 Linting WordPress with this PR took 47.94s vs 47.74s on master (0% slower)

Generated by 🚫 Danger

@jpsim jpsim merged commit 406a8f2 into realm:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants