Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raw_value_for_camel_cased_codable_enum (#2888) #2889

Merged
merged 5 commits into from
Oct 21, 2019
Merged

Add raw_value_for_camel_cased_codable_enum (#2888) #2889

merged 5 commits into from
Oct 21, 2019

Conversation

fddecc
Copy link
Contributor

@fddecc fddecc commented Oct 2, 2019

This PR implements #2888

@fddecc fddecc changed the title Implement #2888 Add snake_case_raw_value_codable_string_enum Oct 2, 2019
@fddecc fddecc changed the title Add snake_case_raw_value_codable_string_enum Add snake_case_raw_value_codable_string_enum (#2888) Oct 2, 2019
@fddecc fddecc mentioned this pull request Oct 2, 2019
Closed
2 tasks
@fddecc fddecc changed the title Add snake_case_raw_value_codable_string_enum (#2888) Add raw_value_for_camel_cased_codable_enum (#2888) Oct 2, 2019
@SwiftLintBot
Copy link

SwiftLintBot commented Oct 3, 2019 •
edited
Loading

14 Warnings
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:5:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:6:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:7:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:8:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:9:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:10:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:11:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:12:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:13:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:14:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:15:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:16:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:17:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
⚠️ This PR introduced a violation in Kickstarter: /Users/vsts/agent/2.158.0/work/1/s/osscheck/Kickstarter/Library/Currency.swift:18:8: warning: Raw Value For Camel Cased Codable Enum Violation: Camel cased cases of Codable String enums should have raw value. (raw_value_for_camel_cased_codable_enum)
12 Messages
📖 Linting Aerial with this PR took 2.32s vs 2.21s on master (4% slower)
📖 Linting Alamofire with this PR took 4.21s vs 4.05s on master (3% slower)
📖 Linting Firefox with this PR took 12.69s vs 11.98s on master (5% slower)
📖 Linting Kickstarter with this PR took 27.6s vs 26.35s on master (4% slower)
📖 Linting Moya with this PR took 2.36s vs 2.4s on master (1% faster)
📖 Linting Nimble with this PR took 2.45s vs 2.42s on master (1% slower)
📖 Linting Quick with this PR took 1.01s vs 0.97s on master (4% slower)
📖 Linting Realm with this PR took 3.97s vs 3.75s on master (5% slower)
📖 Linting SourceKitten with this PR took 1.72s vs 1.62s on master (6% slower)
📖 Linting Sourcery with this PR took 4.53s vs 4.27s on master (6% slower)
📖 Linting Swift with this PR took 21.16s vs 20.96s on master (0% slower)
📖 Linting WordPress with this PR took 29.14s vs 29.1s on master (0% slower)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit a9ae253 into realm:master Oct 21, 2019
@marcelofabri
Copy link
Collaborator

Thanks @00FA9A! 🙌

@marcelofabri marcelofabri mentioned this pull request Oct 21, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelofabri marcelofabri marcelofabri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fddecc @SwiftLintBot @marcelofabri