-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use swift enums instead of raw values #2924
Merged
PaulTaykalo
merged 4 commits into
master
from
speedup/use-swift-declaration-kinds-enums-instead-of-rawValues
Nov 7, 2019
Merged
Use swift enums instead of raw values #2924
PaulTaykalo
merged 4 commits into
master
from
speedup/use-swift-declaration-kinds-enums-instead-of-rawValues
Nov 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulTaykalo
added
discussion
Topics that cannot be categorized as bugs or enhancements yet. They require further discussions.
enhancement
Ideas for improvements of existing features and rules.
labels
Oct 27, 2019
Generated by 🚫 Danger |
jpsim
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 worth calling out the performance improvements in the changelog too!
PaulTaykalo
force-pushed
the
speedup/cache-structure-dictionaries
branch
2 times, most recently
from
November 7, 2019 08:28
796cac6
to
4fff698
Compare
PaulTaykalo
changed the base branch from
speedup/cache-structure-dictionaries
to
master
November 7, 2019 08:56
PaulTaykalo
force-pushed
the
speedup/use-swift-declaration-kinds-enums-instead-of-rawValues
branch
from
November 7, 2019 09:05
6497350
to
b1cdc11
Compare
PaulTaykalo
deleted the
speedup/use-swift-declaration-kinds-enums-instead-of-rawValues
branch
November 7, 2019 17:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
discussion
Topics that cannot be categorized as bugs or enhancements yet. They require further discussions.
enhancement
Ideas for improvements of existing features and rules.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have own dictionary, no need to have calculated properties for some parameters in dictionaries.
A lot of time was spent on conversion from
stringKind
of elements to some specific enum (i.e.SwiftDeclarationKind
,StatementKind
,SwiftExpressionKind
)These were pre-cached in the dictionary, which allowed to
Note
kind
as a string because there are no enums or enum cases that represent those stringsSourceKittenDictionary
, we need to be careful, because if properties will take too much place in memory,SourceKittenDictionary
will start behaving like aclass
and will be put on the heap.