Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives when line ends with carriage return + line feed #3061

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Fix false positives when line ends with carriage return + line feed #3061

merged 1 commit into from
Feb 2, 2020

Conversation

john-mueller
Copy link
Contributor

Fixes: #3060

I wasn't exactly sure where the test should go, so I added it in its own file. If there's a better place for it, I'm happy to move it.

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 1.24s vs 1.18s on master (5% slower)
📖 Linting Alamofire with this PR took 2.21s vs 2.21s on master (0% slower)
📖 Linting Firefox with this PR took 9.09s vs 8.95s on master (1% slower)
📖 Linting Kickstarter with this PR took 14.87s vs 14.7s on master (1% slower)
📖 Linting Moya with this PR took 1.16s vs 1.21s on master (4% faster)
📖 Linting Nimble with this PR took 1.38s vs 1.35s on master (2% slower)
📖 Linting Quick with this PR took 0.53s vs 0.53s on master (0% slower)
📖 Linting Realm with this PR took 2.36s vs 2.34s on master (0% slower)
📖 Linting SourceKitten with this PR took 1.02s vs 1.03s on master (0% faster)
📖 Linting Sourcery with this PR took 6.7s vs 6.75s on master (0% faster)
📖 Linting Swift with this PR took 12.46s vs 12.38s on master (0% slower)
📖 Linting WordPress with this PR took 15.08s vs 15.07s on master (0% slower)

Generated by 🚫 Danger

@PaulTaykalo PaulTaykalo self-requested a review January 31, 2020 23:35
@marcelofabri marcelofabri merged commit be44017 into realm:master Feb 2, 2020
@marcelofabri
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive when line ends with carriage return ("\r\n")
4 participants