Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tuple_pattern opt-in rule #3086

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Add tuple_pattern opt-in rule #3086

merged 2 commits into from
Feb 8, 2020

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2203

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 8, 2020

11 Warnings
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressThisWeekWidget/ThisWeekViewController.swift:123:53: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressThisWeekWidget/ThisWeekViewController.swift:358:23: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/RestorePostTableViewCell.swift:18:23: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Site Creation/SiteInfo/SiteInformationWizardContent.swift:322:24: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift:606:30: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Notifications/Views/NoteBlockUserTableViewCell.swift:97:20: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Shared Views/TopTotalsCell.swift:296:22: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressAllTimeWidget/AllTimeViewController.swift:123:59: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressAllTimeWidget/AllTimeViewController.swift:354:23: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressTodayWidget/TodayViewController.swift:123:59: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressTodayWidget/TodayViewController.swift:354:23: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided. (void_function_in_ternary)
12 Messages
📖 Linting Aerial with this PR took 1.3s vs 1.23s on master (5% slower)
📖 Linting Alamofire with this PR took 2.3s vs 2.27s on master (1% slower)
📖 Linting Firefox with this PR took 9.67s vs 9.26s on master (4% slower)
📖 Linting Kickstarter with this PR took 15.88s vs 15.49s on master (2% slower)
📖 Linting Moya with this PR took 1.28s vs 1.22s on master (4% slower)
📖 Linting Nimble with this PR took 1.43s vs 1.39s on master (2% slower)
📖 Linting Quick with this PR took 0.56s vs 0.6s on master (6% faster)
📖 Linting Realm with this PR took 2.47s vs 2.43s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.09s vs 1.04s on master (4% slower)
📖 Linting Sourcery with this PR took 7.07s vs 6.94s on master (1% slower)
📖 Linting Swift with this PR took 13.07s vs 12.79s on master (2% slower)
📖 Linting WordPress with this PR took 15.98s vs 15.48s on master (3% slower)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit f95768d into master Feb 8, 2020
jpsim added a commit that referenced this pull request Feb 11, 2020
@marcelofabri marcelofabri deleted the mf-tuple-pattern branch April 17, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rule Request] Tuple Pattern Rule
2 participants