-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ConditionalBindingCascadeRule #327
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b7a846b
Adding ConditionalBindingCascadeRule
c068a28
Improve performance of ConditionalBindingCascadeRule
bbc28cb
Remove unnecessary whitespace
6980a2d
Fix initial newline
30dd848
Fixed alphabetising list
505eceb
Merge remote-tracking branch 'realm/master' into add-conditional-bind…
b82d8a9
Fix rebase
f9bafd8
Add message to XCTAssert failure for non-triggering rule violations
d0c83c8
Revert "Add message to XCTAssert failure for non-triggering rule viol…
52c632f
Fixed two more edge cases for non-triggering examples
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
Source/SwiftLintFramework/Rules/ConditionalBindingCascadeRule.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // | ||
| // ConditionalBindingCascadeRule.swift | ||
| // SwiftLint | ||
| // | ||
| // Created by Aaron McTavish on 08/01/2016. | ||
| // Copyright © 2016 Realm. All rights reserved. | ||
| // | ||
|
|
||
| import SourceKittenFramework | ||
|
|
||
| public struct ConditionalBindingCascadeRule: Rule { | ||
| public static let description = RuleDescription( | ||
| identifier: "conditional_binding_cascade", | ||
| name: "Conditional Binding Cascade", | ||
| description: "Repeated `let` statements in conditional binding cascade should be avoided.", | ||
| nonTriggeringExamples: [ | ||
| "if let a = b, c = d {", | ||
| "if let a = b, \n c = d {", | ||
| "if let a = b, \n c = d \n {", | ||
| "if let a = b { if let c = d {", | ||
| "if let a = b { let c = d({ foo in ... })", | ||
| "guard let a = b, c = d else {" | ||
| ], | ||
| triggeringExamples: [ | ||
| "if let a = b, let c = d {", | ||
| "if let a = b, \n let c = d {", | ||
| "if let a = b, c = d, let e = f {", | ||
| "if let a = b, let c = d \n {", | ||
| "if \n let a = b, let c = d {", | ||
| "if let a = b, c = d.indexOf({$0 == e}), let f = g {", | ||
| "guard let a = b, let c = d else {" | ||
| ] | ||
| ) | ||
|
|
||
| public func validateFile(file: File) -> [StyleViolation] { | ||
| let conditionalBindingKeywords = ["if", "guard"] | ||
| let pattern = "^(" + | ||
| conditionalBindingKeywords.joinWithSeparator("|") + | ||
| ")(\\s*?)let((.|\\s)*?),(\\s*?)let((.|\\s)*?)\\{" | ||
| return file.matchPattern(pattern, | ||
| excludingSyntaxKinds: SyntaxKind.commentAndStringKinds()).map { | ||
| StyleViolation(ruleDescription: self.dynamicType.description, | ||
| location: Location(file: file, characterOffset: $0.location)) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the two trailing spaces as described in CONTRIBUTING.md.