Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger closure_parameter_position in free closures and capture lists #3281

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

marcelofabri
Copy link
Collaborator

@marcelofabri marcelofabri commented Aug 5, 2020

Fixes #3225

@SwiftLintBot
Copy link

10 Warnings
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Firefox: /Sync/StorageClient.swift:346:14: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in Firefox: /SyncTests/RecordTests.swift:126:14: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in Firefox: /SyncTests/RecordTests.swift:131:14: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in Kickstarter: /Library/PaginateTests.swift:532:7: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/RaceTest.swift:629:6: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Tools/SettingsCommon.swift:53:13: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Tools/SettingsCommon.swift:74:13: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Domain Credit/DomainCreditRedemptionSuccessViewController.swift:26:25: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Me/Account Settings/AccountSettingsViewController.swift:209:13: warning: Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace. (closure_parameter_position)
12 Messages
📖 Linting Aerial with this PR took 1.71s vs 1.67s on master (2% slower)
📖 Linting Alamofire with this PR took 2.66s vs 2.66s on master (0% slower)
📖 Linting Firefox with this PR took 9.08s vs 8.94s on master (1% slower)
📖 Linting Kickstarter with this PR took 15.08s vs 14.74s on master (2% slower)
📖 Linting Moya with this PR took 1.36s vs 1.3s on master (4% slower)
📖 Linting Nimble with this PR took 1.4s vs 1.37s on master (2% slower)
📖 Linting Quick with this PR took 0.65s vs 0.63s on master (3% slower)
📖 Linting Realm with this PR took 2.69s vs 2.66s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.04s vs 1.03s on master (0% slower)
📖 Linting Sourcery with this PR took 7.2s vs 7.22s on master (0% faster)
📖 Linting Swift with this PR took 10.79s vs 10.88s on master (0% faster)
📖 Linting WordPress with this PR took 16.65s vs 16.74s on master (0% faster)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit 8638d23 into master Aug 5, 2020
@marcelofabri marcelofabri deleted the marcelo/bugfix-3225 branch August 5, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

closure_parameter_position not triggering with lack of parameter in closure
2 participants