Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnusedDeclarationRule] Add more tests #3359

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Sep 21, 2020

No description provided.

@jpsim jpsim marked this pull request as ready for review September 21, 2020 18:59
@SwiftLintBot
Copy link

2 Warnings
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 1.92s vs 1.88s on master (2% slower)
📖 Linting Alamofire with this PR took 2.76s vs 2.68s on master (2% slower)
📖 Linting Firefox with this PR took 9.33s vs 9.18s on master (1% slower)
📖 Linting Kickstarter with this PR took 15.44s vs 15.24s on master (1% slower)
📖 Linting Moya with this PR took 1.26s vs 1.34s on master (5% faster)
📖 Linting Nimble with this PR took 1.39s vs 1.31s on master (6% slower)
📖 Linting Quick with this PR took 0.64s vs 0.63s on master (1% slower)
📖 Linting Realm with this PR took 2.64s vs 2.66s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.02s vs 0.98s on master (4% slower)
📖 Linting Sourcery with this PR took 7.11s vs 7.1s on master (0% slower)
📖 Linting Swift with this PR took 10.88s vs 10.79s on master (0% slower)
📖 Linting WordPress with this PR took 16.96s vs 16.8s on master (0% slower)

Here's an example of your CHANGELOG entry:

* [UnusedDeclarationRule] Add more tests.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #3359 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
+ Coverage   90.46%   90.52%   +0.05%     
==========================================
  Files         417      417              
  Lines       20434    20434              
==========================================
+ Hits        18486    18498      +12     
+ Misses       1948     1936      -12     
Impacted Files Coverage Δ
...ntFramework/Rules/Lint/UnusedDeclarationRule.swift 85.61% <ø> (+0.71%) ⬆️
...mework/Rules/Idiomatic/NoFallthroughOnlyRule.swift 100.00% <0.00%> (+1.92%) ⬆️
...ftLintFramework/Rules/Lint/PrivateOutletRule.swift 100.00% <0.00%> (+3.84%) ⬆️
...ramework/Rules/Style/NoSpaceInMethodCallRule.swift 100.00% <0.00%> (+15.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d6c2e...332450a. Read the comment docs.

@jpsim jpsim merged commit f71394a into master Sep 21, 2020
@jpsim jpsim deleted the unuseddeclarationrule-add-more-tests branch September 21, 2020 19:10
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Oct 4, 2020
* master-upstream: (98 commits)
  Fix some false positives in rule `explicit_self` (realm#3368)
  Update SourceKitten to 0.30.1 (realm#3367)
  Fix issues with analyzer rules, Xcode 12 & SwiftUI (realm#3366)
  Add empty changelog section
  release 0.40.3
  Fix false positives for 'multiple_closures_with_trailing_closure' (realm#3353)
  [UnusedDeclarationRule] Work around SR-11985 (realm#3363)
  Revert "Fix finding the nested config when a single file path is passed (realm#3342)" (realm#3362)
  [CONTRIBUTING] Add building & running tips (realm#3360)
  Fix finding the nested config when a single file path is passed (realm#3342)
  Include Linux zip in list of GitHub release binaries (realm#3350)
  [UnusedDeclarationRule] Add more tests (realm#3359)
  Test CI with official Swift 5.3 release (realm#3356)
  Don't mark `@NSApplicationMain` or `@UIApplicationMain` classes as unused (realm#3355)
  [Fix] `UnusedCaptureListRule`: implicit self in @escaping closures (realm#3352)
  Skip correcting files with parser diagnostics (realm#3349)
  [SwiftLintFile] Remove lock in favor of UUID (realm#3347)
  [UnusedDeclarationRule] Speed up and detect more dead code (realm#3340)
  Add empty changelog section
  release 0.40.2
  ...

# Conflicts:
#	Source/swiftlint/Helpers/LintableFilesVisitor.swift
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Oct 4, 2020
* master: (98 commits)
  Fix some false positives in rule `explicit_self` (realm#3368)
  Update SourceKitten to 0.30.1 (realm#3367)
  Fix issues with analyzer rules, Xcode 12 & SwiftUI (realm#3366)
  Add empty changelog section
  release 0.40.3
  Fix false positives for 'multiple_closures_with_trailing_closure' (realm#3353)
  [UnusedDeclarationRule] Work around SR-11985 (realm#3363)
  Revert "Fix finding the nested config when a single file path is passed (realm#3342)" (realm#3362)
  [CONTRIBUTING] Add building & running tips (realm#3360)
  Fix finding the nested config when a single file path is passed (realm#3342)
  Include Linux zip in list of GitHub release binaries (realm#3350)
  [UnusedDeclarationRule] Add more tests (realm#3359)
  Test CI with official Swift 5.3 release (realm#3356)
  Don't mark `@NSApplicationMain` or `@UIApplicationMain` classes as unused (realm#3355)
  [Fix] `UnusedCaptureListRule`: implicit self in @escaping closures (realm#3352)
  Skip correcting files with parser diagnostics (realm#3349)
  [SwiftLintFile] Remove lock in favor of UUID (realm#3347)
  [UnusedDeclarationRule] Speed up and detect more dead code (realm#3340)
  Add empty changelog section
  release 0.40.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants