Add option warnings-as-errors to lint & analyze #3371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Jeehut
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3371 +/- ##
==========================================
- Coverage 90.48% 90.46% -0.03%
==========================================
Files 417 417
Lines 20508 20524 +16
==========================================
+ Hits 18557 18567 +10
- Misses 1951 1957 +6
Continue to review full report at Codecov.
|
|
Closed as #3372 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementes #3312.
I tested that this works manually by building via
swift build -c releaseand running.build/release/swiftlint --warnings-as-errorsand it worked just as expected. Without that option, I had 1 warning & 1 error reported, with that options 2 errors were reported, so I can confirm it works. But I did not add any unit tests because there seem to be no unit tests for the CLI product, other options like--lenientseem also not to be unit tested.Note that I did not mess with any tresholds (like
lenientdoes), I think we could think about those things after seeing how people are using this new option, so I'd rather keep this simple for now.