Add TestCaseAccessibilityRule

Source/SwiftLintFramework/Helpers/XCTestHelpers.swift

@@ -1,24 +1,14 @@
 import SourceKittenFramework
 
-private let testFunctionNames: Set = [
-    "setUp()",
-    "setUpWithError()",
-    "tearDown()",
-    "tearDownWithError()"
-]
-
 private let testVariableNames: Set = [
     "allTests"
 ]
 
 enum XCTestHelpers {
-    static func isXCTestMember(kind: SwiftDeclarationKind, name: String) -> Bool {
-        if SwiftDeclarationKind.functionKinds.contains(kind) {
-            return name.hasPrefix("test") || testFunctionNames.contains(name)
-        } else if SwiftDeclarationKind.variableKinds.contains(kind) {
-            return testVariableNames.contains(name)
-        }
-
-        return false
+    static func isXCTestMember(kind: SwiftDeclarationKind, name: String,
+                               attributes: [SwiftDeclarationAttributeKind]) -> Bool {
+        return attributes.contains(.override)
+            || (kind == .functionMethodInstance && name.hasPrefix("test"))
+            || ([.varStatic, .varClass].contains(kind) && testVariableNames.contains(name))
     }
 }

Source/SwiftLintFramework/Rules/Lint/EmptyXCTestMethodRule.swift

@@ -34,7 +34,8 @@ public struct EmptyXCTestMethodRule: Rule, OptInRule, ConfigurationProviderRule,
             guard
                 let kind = subDictionary.declarationKind,
                 let name = subDictionary.name,
-                XCTestHelpers.isXCTestMember(kind: kind, name: name),
+                XCTestHelpers.isXCTestMember(kind: kind, name: name,
+                                             attributes: subDictionary.enclosedSwiftAttributes),
                 let offset = subDictionary.offset,
                 subDictionary.enclosedVarParameters.isEmpty,
                 subDictionary.substructure.isEmpty else { return nil }

Source/SwiftLintFramework/Rules/Lint/TestCaseAccessibilityRule.swift

@@ -23,8 +23,7 @@ public struct TestCaseAccessibilityRule: Rule, OptInRule, ConfigurationProviderR
     private func testClasses(in file: SwiftLintFile) -> [SourceKittenDictionary] {
         let dict = file.structureDictionary
         return dict.substructure.filter { dictionary in
-            dictionary.declarationKind == .class &&
-                dictionary.inheritedTypes.contains("XCTestCase")
+            dictionary.declarationKind == .class && dictionary.inheritedTypes.contains("XCTestCase")
         }
     }
 
@@ -35,7 +34,7 @@ public struct TestCaseAccessibilityRule: Rule, OptInRule, ConfigurationProviderR
                 let kind = subDictionary.declarationKind,
                 kind != .varLocal,
                 let name = subDictionary.name,
-                !isXCTestMember(kind: kind, name: name),
+                !isXCTestMember(kind: kind, name: name, attributes: subDictionary.enclosedSwiftAttributes),
                 let offset = subDictionary.offset,
                 subDictionary.accessibility?.isPrivate != true else { return nil }
 
@@ -45,8 +44,9 @@ public struct TestCaseAccessibilityRule: Rule, OptInRule, ConfigurationProviderR
         }
     }
 
-    private func isXCTestMember(kind: SwiftDeclarationKind, name: String) -> Bool {
-        return XCTestHelpers.isXCTestMember(kind: kind, name: name)
-            || configuration.methodPrefixes.contains(where: name.hasPrefix)
+    private func isXCTestMember(kind: SwiftDeclarationKind, name: String,
+                                attributes: [SwiftDeclarationAttributeKind]) -> Bool {
+        return XCTestHelpers.isXCTestMember(kind: kind, name: name, attributes: attributes)
+            || configuration.allowedPrefixes.contains(where: name.hasPrefix)
     }
 }

Source/SwiftLintFramework/Rules/Lint/TestCaseAccessibilityRuleExamples.swift

@@ -6,6 +6,8 @@ internal struct TestCaseAccessibilityRuleExamples {
         let foo: String?
 
         class FooTests: XCTestCase {
+            static let allTests: [String] = []
+
             private let foo: String {
                 let nestedMember = "hi"
                 return nestedMember
@@ -35,6 +37,10 @@ internal struct TestCaseAccessibilityRuleExamples {
                 try super.tearDownWithError()
             }
 
+            override func someFutureXCTestFunction() {
+                super.someFutureXCTestFunction()
+            }
+
             func testFoo() {
                 XCTAssertTrue(true)
             }
@@ -69,6 +75,10 @@ internal struct TestCaseAccessibilityRuleExamples {
             ↓func not_testBar() {}
 
             ↓enum Nested {}
+
+            ↓static func testFoo() {}
+
+            ↓static func allTests() {}
         }
 
         final class BarTests: XCTestCase {

Source/SwiftLintFramework/Rules/RuleConfigurations/TestCaseAccessibilityConfiguration.swift

@@ -1,10 +1,10 @@
 public struct TestCaseAccessibilityConfiguration: RuleConfiguration, Equatable {
     public private(set) var severityConfiguration = SeverityConfiguration(.warning)
-    public private(set) var methodPrefixes: Set<String> = []
+    public private(set) var allowedPrefixes: Set<String> = []
 
     public var consoleDescription: String {
         return severityConfiguration.consoleDescription +
-        	", method_prefixes: [\(methodPrefixes)]"
+            ", allowed_prefixes: [\(allowedPrefixes)]"
     }
 
     public mutating func apply(configuration: Any) throws {
@@ -16,8 +16,8 @@ public struct TestCaseAccessibilityConfiguration: RuleConfiguration, Equatable {
             try severityConfiguration.apply(configuration: severityString)
         }
 
-        if let methodPrefixes = configuration["method_prefixes"] as? [String] {
-            self.methodPrefixes = Set(methodPrefixes)
+        if let allowedPrefixes = configuration["allowed_prefixes"] as? [String] {
+            self.allowedPrefixes = Set(allowedPrefixes)
         }
     }