Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bool violation reporting in redundant_type_annotation #3438

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

agarmash
Copy link
Contributor

Fixed the issue and refactored the code a bit.
Resolves #3423

@SwiftLintBot
Copy link

SwiftLintBot commented Nov 19, 2020

242 Warnings
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:22:34: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:178:20: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:90:40: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:92:27: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /WidgetKit/OpenTabs/SimpleTab.swift:14:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /ClientTests/DownloadQueueTests.swift:100:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /ClientTests/DownloadQueueTests.swift:101:25: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /ClientTests/ResetTests.swift:27:23: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /ClientTests/MockProfile.swift:163:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Shared/AsyncReducer.swift:40:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Shared/Extensions/URLExtensions.swift:11:15: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Shared/Extensions/URLExtensions.swift:12:20: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Providers/Profile.swift:602:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Storage/ReadingList.swift:12:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Storage/ReadingList.swift:13:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Storage/ReadingList.swift:14:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Storage/Rust/RustPlaces.swift:23:39: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Storage/Rust/RustLogins.swift:93:32: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Extensions/NotificationService/NotificationService.swift:87:25: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Sync/EncryptedJSON.swift:28:14: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Sync/EncryptedJSON.swift:29:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /SyncTests/HistorySynchronizerTests.swift:29:17: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Settings/SettingsTableViewController.swift:62:16: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Settings/LoginDetailViewController.swift:56:39: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Settings/SettingsContentViewController.swift:23:17: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Settings/SettingsContentViewController.swift:37:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Settings/AppSettingsOptions.swift:14:30: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListViewModel.swift:36:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Library/ReaderPanel.swift:68:15: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginDetailTableViewCell.swift:114:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginDetailTableViewCell.swift:120:27: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListViewController.swift:42:25: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ReaderModeBarView.swift:130:15: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ReaderModeBarView.swift:139:14: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Extensions/DevicePickerViewController.swift:312:16: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabPeekViewController.swift:27:33: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabPeekViewController.swift:28:36: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabPeekViewController.swift:29:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabPeekViewController.swift:30:30: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/OpenWithSettingsViewController.swift:58:36: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/URLBarView.swift:72:24: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift:9:19: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListViewController.swift:64:24: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:48:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:49:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab.swift:46:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab.swift:53:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab.swift:118:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab.swift:128:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab.swift:177:25: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabScrollController.swift:44:32: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabScrollController.swift:46:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift:15:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Widgets/DrawerViewController.swift:43:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Widgets/AutocompleteTextField.swift:26:27: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheetWidgets.swift:70:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheetAnimator.swift:9:19: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Widgets/TwoLineCell.swift:194:22: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Widgets/SearchInputView.swift:29:25: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift:72:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Firefox: /Client/Application/LeanplumIntegration.swift:134:24: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/TestHelpers/MockOptimizelyResult.swift:5:20: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Views/Cells/BackerDashboardEmptyStateCell.swift:12:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Views/Cells/DiscoverySelectableRowCell.swift:8:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Views/Cells/DiscoveryExpandedSelectableRow.swift:11:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Views/Layouts/PillLayout.swift:5:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Views/LoadingButton.swift:22:23: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Library/TestHelpers/MockApplePayCapable.swift:8:24: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Library/TestHelpers/MockApplePayCapable.swift:9:23: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Library/TestHelpers/MockApplePayCapable.swift:10:34: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Library/TestHelpers/MockOptimizelyClient.swift:15:25: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Kickstarter: /Library/TestHelpers/MockOptimizelyClient.swift:20:27: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Nimble: /Sources/Nimble/Adapters/NimbleXCTestHandler.swift:45:58: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Nimble: /Sources/Nimble/Adapters/NimbleEnvironment.swift:31:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Nimble: /Sources/Nimble/Matchers/PostNotification.swift:51:13: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Nimble: /Sources/Nimble/Matchers/PostNotification.swift:116:13: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Nimble: /Tests/NimbleTests/AsynchronousTest.swift:204:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Nimble: /Tests/NimbleTests/AsynchronousTest.swift:218:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Realm: /RealmSwift/RealmConfiguration.swift:171:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Realm: /RealmSwift/RealmConfiguration.swift:199:50: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Realm: /RealmSwift/RealmConfiguration.swift:250:42: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/KVOTests.swift:32:30: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/CodableTests.swift:33:27: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in SourceKitten: /Source/sourcekitten/Format.swift:12:27: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in SourceKitten: /Source/sourcekitten/Format.swift:14:20: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in SourceKitten: /Source/sourcekitten/Doc.swift:10:23: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in SourceKitten: /Source/sourcekitten/Doc.swift:14:16: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in SourceKitten: /Source/sourcekitten/Doc.swift:16:17: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryRuntime/Sources/Log.swift:15:36: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryFramework/Sources/Parsing/Utils/AnnotationsParser.swift:200:24: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryFramework/Sources/Parsing/Utils/AnnotationsParser.swift:201:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryFramework/Sources/Parsing/FileParser.swift:704:23: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Yams/Sources/Yams/Emitter.swift:208:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Yams/Sources/Yams/Emitter.swift:214:32: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Yams/Sources/Yams/Emitter.swift:219:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Yams/Sources/Yams/Emitter.swift:220:24: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Yams/Sources/Yams/Emitter.swift:226:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/xcproj/Sources/xcproj/PBXProjEncoder.swift:18:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Nimble/Sources/Nimble/Adapters/NimbleXCTestHandler.swift:45:58: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Nimble/Sources/Nimble/Adapters/NimbleEnvironment.swift:31:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Nimble/Sources/Nimble/Matchers/PostNotification.swift:51:13: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /Pods/Nimble/Sources/Nimble/Matchers/PostNotification.swift:116:13: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Views/Text Fields/TextField.swift:5:33: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Views/Text Fields/TextField.swift:6:37: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/PlaceBidViewController.swift:14:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/BridgeObjectiveC.swift:123:53: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/OptionSet.swift:147:10: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Zip.swift:94:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Stride.swift:422:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift:3006:15: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift:3228:16: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Darwin/XCTest/XCTest.swift:388:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Darwin/XCTest/XCTest.swift:464:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Darwin/Foundation/NSIndexSet.swift:20:22: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Darwin/Foundation/Data.swift:305:18: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/SwiftPrivate/IO.swift:24:19: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/SwiftPrivate/IO.swift:85:22: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/SwiftPrivate/IO.swift:86:19: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/SwiftPrivate/IO.swift:197:22: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Darwin/Foundation/Calendar.swift:422:19: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/RaceTest.swift:517:16: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/StdlibUnittest.swift:1392:34: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/StdlibUnittest.swift:1393:33: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/StdlibUnittest.swift:1394:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/StdlibUnittest.swift:1455:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/StdlibUnittest.swift:1655:28: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/StdlibUnittest.swift:1658:30: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Models/JetpackState.swift:8:26: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Models/Page.swift:7:31: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/UIColor+MurielColors.swift:334:29: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
⚠️ Danger found 242 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 131.
12 Messages
📖 Linting Aerial with this PR took 2.01s vs 2.0s on master (0% slower)
📖 Linting Alamofire with this PR took 2.85s vs 2.83s on master (0% slower)
📖 Linting Firefox with this PR took 9.52s vs 9.45s on master (0% slower)
📖 Linting Kickstarter with this PR took 15.47s vs 15.43s on master (0% slower)
📖 Linting Moya with this PR took 1.46s vs 1.41s on master (3% slower)
📖 Linting Nimble with this PR took 1.34s vs 1.33s on master (0% slower)
📖 Linting Quick with this PR took 0.6s vs 0.58s on master (3% slower)
📖 Linting Realm with this PR took 4.35s vs 4.39s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.05s vs 1.02s on master (2% slower)
📖 Linting Sourcery with this PR took 7.65s vs 7.61s on master (0% slower)
📖 Linting Swift with this PR took 11.15s vs 11.11s on master (0% slower)
📖 Linting WordPress with this PR took 17.34s vs 17.28s on master (0% slower)

Generated by 🚫 Danger

@agarmash agarmash force-pushed the redundant_type_annotation_bool branch from dbbe426 to 418e274 Compare December 8, 2020 08:04
@stale
Copy link

stale bot commented Feb 6, 2021

This issue has been automatically marked as stale because it has not had any recent activity. Please comment to prevent this issue from being closed. Thank you for your contributions!

@stale stale bot added the wontfix Issues that became stale and were auto-closed by a bot. label Feb 6, 2021
@revolter
Copy link
Contributor

revolter commented Feb 6, 2021

This is not stale.

@stale stale bot removed the wontfix Issues that became stale and were auto-closed by a bot. label Feb 6, 2021
@jpsim
Copy link
Collaborator

jpsim commented Feb 24, 2021

Thanks @agarmash and @revolter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valid violation not reported by redundant_type_annotation for Bool
4 participants