[Analyze] Support compile commands with relative paths #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
approved these changes
Jan 22, 2021
And made small formatting edits to other recent entries.
|
Maybe too aggressive but we could make this fail if it didn't find either |
Yeah that's too aggressive IMO. It's convenient to have files that you want to lint but don't have compilation commands when analyzing. For example, sample code, unit tests or sources that don't compile easily with the target you're analyzing. Logging a warning might be appropriate though, but again depending on the configuration could be overly noisy. |
Generated by 🚫 Danger |
jpsim
deleted the
analyze-support-compile-commands-with-relative-paths
branch
DwayneCoussement
pushed a commit
to DwayneCoussement/SwiftLint
that referenced
this pull request
Jan 27, 2021
* [Analyze] Support compile commands with relative paths * Add changelog entry And made small formatting edits to other recent entries.
DwayneCoussement
added a commit
to DwayneCoussement/SwiftLint
that referenced
this pull request
Jan 27, 2021
Separate custom rules merging & filtering to avoid misleading warnings Add changelog entry Fix custom_rules merging when a configuration is based on only_rules Fix if statement formatting Fix changelog [realm#3477] Fix bug that prevented the reconfiguration of a custom rule in a child config Add newline at end of yml test file [Analyze] Support compile commands with relative paths (realm#3501) * [Analyze] Support compile commands with relative paths * Add changelog entry And made small formatting edits to other recent entries. Update rule: uiimage_require_bundle
DwayneCoussement
pushed a commit
to DwayneCoussement/SwiftLint
that referenced
this pull request
Feb 1, 2021
commit bbf1ad4 Author: JP Simard <jp@jpsim.com> Date: Fri Jan 29 13:59:28 2021 -0500 [ExplicitSelfRule] Fix violation location and misplaced corrections (realm#3507) commit 59eb887 Author: Otavio Cordeiro <otaviocc@users.noreply.github.com> Date: Fri Jan 29 18:30:57 2021 +0100 Add opt-in rule discouraged_assert (realm#3506) Co-authored-by: Keith Smiley <keithbsmiley@gmail.com> commit 6a38b15 Author: JP Simard <jp@jpsim.com> Date: Fri Jan 22 13:31:05 2021 -0500 Revert "Merge pull request realm#3473 from realm/feature/3472-fix-custom-rules-merging" (realm#3503) This reverts commit 537e53f, reversing changes made to ba49f7d. commit 6de5771 Author: JP Simard <jp@jpsim.com> Date: Fri Jan 22 12:44:30 2021 -0500 [Analyze] Support compile commands with relative paths (realm#3501) * [Analyze] Support compile commands with relative paths * Add changelog entry And made small formatting edits to other recent entries. commit 537e53f Merge: ba49f7d 22d25da Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Fri Jan 15 11:53:17 2021 +0100 Merge pull request realm#3473 from realm/feature/3472-fix-custom-rules-merging Multiple Fixes for custom rules commit 22d25da Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Fri Jan 15 00:14:50 2021 +0100 Add newline at end of yml test file commit 2d17045 Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Tue Dec 22 19:41:40 2020 +0100 [realm#3477] Fix bug that prevented the reconfiguration of a custom rule in a child config commit a39e72e Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Mon Dec 21 12:40:53 2020 +0100 Fix changelog commit 56e4f17 Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Sun Dec 20 00:52:17 2020 +0100 Fix if statement formatting commit 5bffc77 Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Sun Dec 20 00:44:49 2020 +0100 Fix custom_rules merging when a configuration is based on only_rules commit e3e169b Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Sat Dec 19 00:11:13 2020 +0100 Add changelog entry commit 256288a Author: Frederick Pietschmann <19194800+fredpi@users.noreply.github.com> Date: Sat Dec 19 00:03:13 2020 +0100 Separate custom rules merging & filtering to avoid misleading warnings
DwayneCoussement
added a commit
to DwayneCoussement/SwiftLint
that referenced
this pull request
Feb 1, 2021
Remove trailing comma Separate custom rules merging & filtering to avoid misleading warnings Add changelog entry Fix custom_rules merging when a configuration is based on only_rules Fix if statement formatting Fix changelog [realm#3477] Fix bug that prevented the reconfiguration of a custom rule in a child config Add newline at end of yml test file [Analyze] Support compile commands with relative paths (realm#3501) * [Analyze] Support compile commands with relative paths * Add changelog entry And made small formatting edits to other recent entries. Update rule: uiimage_require_bundle
DwayneCoussement
added a commit
to DwayneCoussement/SwiftLint
that referenced
this pull request
Feb 2, 2021
Remove trailing comma Separate custom rules merging & filtering to avoid misleading warnings Add changelog entry Fix custom_rules merging when a configuration is based on only_rules Fix if statement formatting Fix changelog [realm#3477] Fix bug that prevented the reconfiguration of a custom rule in a child config Add newline at end of yml test file [Analyze] Support compile commands with relative paths (realm#3501) * [Analyze] Support compile commands with relative paths * Add changelog entry And made small formatting edits to other recent entries. Update rule: uiimage_require_bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.