Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Legacy ObjC Type Rule #2758 #3531

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Feb 23, 2021

Revived from #3110

@jpsim jpsim marked this pull request as ready for review February 23, 2021 19:09
@realm realm deleted a comment from SwiftLintBot Feb 23, 2021
@SwiftLintBot
Copy link

1 Error
🚫 Please rebase to get rid of the merge commits in this PR
3752 Warnings
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/PanelWindowController.swift:110:34: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/PanelWindowController.swift:110:45: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/TimeSetupViewController.swift:26:32: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/TimeSetupViewController.swift:28:31: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/AdvancedViewController.swift:140:34: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/AdvancedViewController.swift:140:45: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/AdvancedViewController.swift:262:32: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/AdvancedViewController.swift:262:43: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/VideosViewController.swift:394:50: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/TimeViewController.swift:23:32: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/TimeViewController.swift:24:31: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/TimeViewController.swift:211:44: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/TimeViewController.swift:217:43: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/Battery.swift:44:28: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/Battery.swift:52:33: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:17:36: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:18:21: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:36:31: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:59:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:79:35: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:95:35: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:164:51: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:221:84: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:233:78: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:20:21: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:25:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:33:38: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:74:31: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:83:32: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:102:44: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:154:78: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:201:35: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:232:35: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:251:51: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:274:35: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:281:35: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:303:84: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:315:78: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:76:25: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:148:21: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:148:32: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:214:43: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:221:44: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:222:43: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:134:40: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:197:53: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:200:52: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:264:70: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:64:57: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:176:61: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:417:48: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:214:54: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:256:50: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:170:83: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:172:24: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:173:51: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/VideoHeaderView.swift:14:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView+Player.swift:111:133: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView+Player.swift:135:83: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoTimerView.swift:12:39: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoTimerView.swift:29:45: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoSettingsView.swift:12:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCountdownView.swift:16:41: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCountdownView.swift:18:44: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCountdownView.swift:56:57: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCountdownView.swift:65:60: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:219:52: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:226:19: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:235:46: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:240:19: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/DisplayView.swift:30:25: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:185:50: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:461:45: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/CheckboxCellView.swift:20:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:13:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:14:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:15:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:16:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:17:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:18:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:19:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:20:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:21:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:22:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:23:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:24:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:25:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:26:15: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:426:46: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:430:46: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:434:46: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:438:46: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:617:70: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Example/Source/DetailViewController.swift:204:100: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/MultipartFormData.swift:246:92: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/ParameterEncoding.swift:199:28: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/ParameterEncoding.swift:311:11: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:94:14: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:96:14: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:96:50: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:96:87: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:97:14: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:97:50: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/SessionDelegate.swift:118:65: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/CacheTests.swift:87:56: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift:978:76: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift:1134:75: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/URLProtocolTests.swift:81:50: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:202:52: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:119:41: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:122:38: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:134:41: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:137:38: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:297:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:298:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:299:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:300:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:305:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/ParameterEncodingTests.swift:306:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationTests.swift:99:91: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/MultipartFormDataTests.swift:784:23: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Alamofire: /Tests/MultipartFormDataTests.swift:827:51: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /StoragePerfTests/StoragePerfTests.swift:13:42: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /ClientTests/FileAccessorTests.swift:14:22: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /ClientTests/FileAccessorTests.swift:14:118: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /ClientTests/FileAccessorTests.swift:66:32: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /ClientTests/PrefsTests.swift:85:61: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /ClientTests/MockProfile.swift:97:42: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /StorageTests/MockFiles.swift:13:42: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /StorageTests/TestSwiftData.swift:24:58: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ This PR introduced a violation in Firefox: /StorageTests/TestBrowserDB.swift:86:77: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
⚠️ Danger found 3752 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 131.
592 Messages
📖 Linting Aerial with this PR took 2.04s vs 2.0s on master (2% slower)
📖 Linting Alamofire with this PR took 2.87s vs 2.86s on master (0% slower)
📖 Linting Firefox with this PR took 9.81s vs 9.81s on master (0% slower)
📖 Linting Kickstarter with this PR took 15.42s vs 15.32s on master (0% slower)
📖 Linting Moya with this PR took 1.41s vs 1.44s on master (2% faster)
📖 Linting Nimble with this PR took 1.27s vs 1.25s on master (1% slower)
📖 Linting Quick with this PR took 0.6s vs 0.61s on master (1% faster)
📖 Linting Realm with this PR took 4.27s vs 4.28s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.04s vs 1.03s on master (0% slower)
📖 Linting Sourcery with this PR took 8.44s vs 8.42s on master (0% slower)
📖 Linting Swift with this PR took 11.33s vs 11.36s on master (0% faster)
📖 Linting WordPress with this PR took 18.56s vs 18.55s on master (0% slower)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/PrefPanel/VideoHeaderView.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoSettingsView.swift:12:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/CheckboxCellView.swift:20:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:13:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:15:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:16:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:17:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:18:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:19:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:20:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:21:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:22:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:23:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:24:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:25:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Sources/DescriptionCellView.swift:26:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Realm: /examples/tvos/swift/DownloadCache/RepositoryCell.swift:22:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Realm: /examples/tvos/swift/DownloadCache/RepositoryCell.swift:23:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Realm: /examples/tvos/swift/PreloadedData/PlacesViewController.swift:23:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Realm: /examples/tvos/swift/DownloadCache/RepositoriesViewController.swift:23:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Realm: /examples/tvos/swift/DownloadCache/RepositoriesViewController.swift:24:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/AppViewController.swift:11:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/ChooseAuctionViewController.swift:51:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminCardTestingViewController.swift:10:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminLogViewController.swift:10:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminPanelViewController.swift:6:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminPanelViewController.swift:56:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminPanelViewController.swift:71:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminPanelViewController.swift:82:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Admin/AdminPanelViewController.swift:83:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/ListingsCountdownManager.swift:6:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/ListingsCountdownManager.swift:7:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:8:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:9:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:10:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:11:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:12:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:15:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:16:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:17:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:18:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:20:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:21:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:22:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:23:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/SwipeCreditCardViewController.swift:12:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/SwipeCreditCardViewController.swift:13:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/SwipeCreditCardViewController.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/SwipeCreditCardViewController.swift:16:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Sale Artwork Details/SaleArtworkDetailsViewController.swift:29:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Sale Artwork Details/SaleArtworkDetailsViewController.swift:30:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/YourBiddingDetailsViewController.swift:13:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/YourBiddingDetailsViewController.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/YourBiddingDetailsViewController.swift:15:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/YourBiddingDetailsViewController.swift:16:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/PlaceBidViewController.swift:26:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/PlaceBidViewController.swift:29:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/PlaceBidViewController.swift:30:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:10:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:13:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:15:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:21:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:22:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderInterestsCollectionViewCell.swift:4:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:26:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:27:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:28:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:29:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:30:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:31:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:33:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:34:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:35:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:37:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderCrossPostCell.swift:10:28: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderCrossPostCell.swift:11:28: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderCrossPostCell.swift:12:28: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderCrossPostCell.swift:13:28: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderCrossPostCell.swift:14:28: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:31:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:32:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:33:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:34:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:35:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:36:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSiteStreamHeader.swift:37:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderBlockedSiteCell.swift:5:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderBlockedSiteCell.swift:6:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderListStreamHeader.swift:5:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderListStreamHeader.swift:6:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderListStreamHeader.swift:7:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderWelcomeBanner.swift:4:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderWelcomeBanner.swift:5:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSavedPostUndoCell.swift:10:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSavedPostUndoCell.swift:11:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSavedPostUndoCell.swift:12:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSavedPostUndoCell.swift:13:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderTagStreamHeader.swift:5:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderTagStreamHeader.swift:6:32: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailCommentsView.swift:5:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailCommentsView.swift:6:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailCommentsView.swift:7:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailCommentsView.swift:8:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:13:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:14:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:15:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:16:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:17:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:18:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:19:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:20:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:21:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:22:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:23:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:24:20: warning: Strong IBOutlet Violation: @IBOutlets shouldn't be declared as weak. (strong_iboutlet)
⚠️ Danger found 592 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 130.

Generated by 🚫 Danger

@jpsim jpsim merged commit eca9ea4 into master Feb 23, 2021
@jpsim jpsim deleted the adding-legacy-objc-type-rule-2758 branch February 23, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants