Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test functions with parameters to TestCaseAccessibilityRule #3612

Conversation

keith
Copy link
Collaborator

@keith keith commented Apr 26, 2021

If a function starts with test but takes some parameters, it is not
actually a test.

@keith keith marked this pull request as ready for review April 26, 2021 19:35
If a function starts with `test` but takes some parameters, it is not
actually a test.
@keith keith force-pushed the ks/add-test-functions-with-parameters-to-testcaseaccessibilityrule branch from 916f330 to 4274c91 Compare April 26, 2021 19:36
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.72s vs 0.72s on master (0% slower)
📖 Linting Alamofire with this PR took 0.97s vs 0.97s on master (0% slower)
📖 Linting Firefox with this PR took 3.33s vs 3.33s on master (0% slower)
📖 Linting Kickstarter with this PR took 5.09s vs 5.1s on master (0% faster)
📖 Linting Moya with this PR took 0.47s vs 0.48s on master (2% faster)
📖 Linting Nimble with this PR took 0.41s vs 0.42s on master (2% faster)
📖 Linting Quick with this PR took 0.19s vs 0.19s on master (0% slower)
📖 Linting Realm with this PR took 1.52s vs 1.54s on master (1% faster)
📖 Linting SourceKitten with this PR took 0.34s vs 0.33s on master (3% slower)
📖 Linting Sourcery with this PR took 3.09s vs 3.09s on master (0% slower)
📖 Linting Swift with this PR took 4.02s vs 4.02s on master (0% slower)
📖 Linting WordPress with this PR took 6.23s vs 6.25s on master (0% faster)

Generated by 🚫 Danger

@jpsim jpsim enabled auto-merge (squash) April 26, 2021 19:48
@jpsim jpsim merged commit 7976b74 into master Apr 26, 2021
@jpsim jpsim deleted the ks/add-test-functions-with-parameters-to-testcaseaccessibilityrule branch April 26, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants