Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Swift Argument Parser and SourceKitten #3733

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Bump Swift Argument Parser and SourceKitten #3733

merged 1 commit into from
Oct 6, 2021

Conversation

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpsim jpsim merged commit b621fb1 into realm:master Oct 6, 2021
@uhooi uhooi deleted the feature/bump_swift_argument_parser_to_stable branch October 6, 2021 02:46
@tiwoc
Copy link

tiwoc commented Oct 18, 2021

@jpsim SourceKitten 0.31.1 fixes an issue with compilation when using Swift 5.5 on Linux (see jpsim/SourceKitten#692). Would it be possible to cut a bugfix release of SwiftLint to ship this PR?


Here's what I did to repro the compile error:

$ docker run -it swift:5.5 /bin/bash

# git clone https://github.com/realm/SwiftLint.git --depth=1 --branch=0.44.0
# cd SwiftLint
# swift build --configuration release
…
Working copy of https://github.com/jpsim/SourceKitten.git resolved at 0.31.0
…
/SwiftLint/.build/checkouts/SourceKitten/Source/SourceKittenFramework/SwiftDocs.swift:27:13: error: cannot find 'fputs' in scope
            fputs(error.description, stderr)
            ^~~~~
/SwiftLint/.build/checkouts/SourceKitten/Source/SourceKittenFramework/SwiftDocs.swift:27:38: error: cannot find 'stderr' in scope
            fputs(error.description, stderr)
                                     ^~~~~~

Current SwiftLint master resolves the issue:

$ docker run -it swift:5.5 /bin/bash

# git clone https://github.com/realm/SwiftLint.git --depth=1 --branch=master
# cd SwiftLint
# swift build --configuration release
…
Working copy of https://github.com/jpsim/SourceKitten.git resolved at 0.31.1
…
[27/27] Build complete!

@jpsim
Copy link
Collaborator

jpsim commented Oct 18, 2021

Sure I'll cut a release today.

@tiwoc
Copy link

tiwoc commented Oct 18, 2021

Awesome, thank you 😎

@jpsim
Copy link
Collaborator

jpsim commented Oct 18, 2021

Done: https://github.com/realm/SwiftLint/releases/tag/0.45.0

@jpsim
Copy link
Collaborator

jpsim commented Oct 18, 2021

Still fighting with Homebrew, but it'll be there today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants