Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle get async and get throws in implicit_getter #3743

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

marcelofabri
Copy link
Collaborator

Fixes #3684

@SwiftLintBot
Copy link

SwiftLintBot commented Oct 12, 2021

1 Warning
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 0.73s vs 0.73s on master (0% slower)
📖 Linting Alamofire with this PR took 0.97s vs 0.97s on master (0% slower)
📖 Linting Firefox with this PR took 3.5s vs 3.5s on master (0% slower)
📖 Linting Kickstarter with this PR took 5.82s vs 5.82s on master (0% slower)
📖 Linting Moya with this PR took 0.48s vs 0.47s on master (2% slower)
📖 Linting Nimble with this PR took 0.41s vs 0.4s on master (2% slower)
📖 Linting Quick with this PR took 0.18s vs 0.19s on master (5% faster)
📖 Linting Realm with this PR took 2.1s vs 2.09s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.33s vs 0.33s on master (0% slower)
📖 Linting Sourcery with this PR took 1.95s vs 1.94s on master (0% slower)
📖 Linting Swift with this PR took 3.09s vs 3.1s on master (0% faster)
📖 Linting WordPress with this PR took 6.44s vs 6.43s on master (0% slower)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit 383e5b5 into master Oct 12, 2021
@marcelofabri marcelofabri deleted the marcelo/3684 branch October 12, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False alarm for new async properties and implicit_getter
2 participants