Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in unused_closure_parameter #3916

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Mar 23, 2022

When using parameters with backticks.

Fixes #3628

When using parameters with backticks.
@jpsim jpsim marked this pull request as ready for review March 23, 2022 19:56
Copy link

@sberrevoets sberrevoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙏🏻

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 23, 2022

1 Warning
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 0.98s vs 0.99s on master (1% faster)
📖 Linting Alamofire with this PR took 1.11s vs 1.11s on master (0% slower)
📖 Linting Firefox with this PR took 4.15s vs 4.16s on master (0% faster)
📖 Linting Kickstarter with this PR took 7.45s vs 7.44s on master (0% slower)
📖 Linting Moya with this PR took 4.43s vs 4.39s on master (0% slower)
📖 Linting Nimble with this PR took 0.4s vs 0.4s on master (0% slower)
📖 Linting Quick with this PR took 0.17s vs 0.17s on master (0% slower)
📖 Linting Realm with this PR took 10.15s vs 9.6s on master (5% slower)
📖 Linting SourceKitten with this PR took 0.33s vs 0.33s on master (0% slower)
📖 Linting Sourcery with this PR took 2.02s vs 2.02s on master (0% slower)
📖 Linting Swift with this PR took 3.16s vs 3.13s on master (0% slower)
📖 Linting WordPress with this PR took 7.42s vs 7.36s on master (0% slower)

Generated by 🚫 Danger

@codecov-commenter
Copy link

Codecov Report

Merging #3916 (a70ebc1) into master (d756541) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   92.55%   92.55%   -0.01%     
==========================================
  Files         437      437              
  Lines       22097    22107      +10     
==========================================
+ Hits        20452    20461       +9     
- Misses       1645     1646       +1     
Impacted Files Coverage Δ
...mework/Rules/Lint/UnusedClosureParameterRule.swift 100.00% <100.00%> (ø)
...iftLintFramework/Extensions/String+SwiftLint.swift 89.39% <0.00%> (-1.52%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jpsim jpsim enabled auto-merge March 23, 2022 20:08
@jpsim jpsim disabled auto-merge March 23, 2022 20:57
@jpsim jpsim merged commit 83a8687 into master Mar 23, 2022
@jpsim jpsim deleted the fix-false-positives-in-unused_closure_parameter branch March 23, 2022 20:57
coffmark pushed a commit to coffmark/SwiftLint that referenced this pull request Apr 11, 2022
When using parameters with backticks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in unused_closure_parameter when using backticks
4 participants