Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for call expressions which are not wrapped into an argument #3977

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented May 13, 2022

This makes the added test cases work in Xcode 13.2 where the wrapping does not happen.
The call expression is the first substructure in the dictionary, while in Xcode 13.3
it's an argument containing the call expression.

Fixes #3975.

@SwiftLintBot
Copy link

SwiftLintBot commented May 13, 2022

97 Messages
📖 Linting Aerial with this PR took 0.34s vs 0.32s on master (6% slower)
📖 Linting Alamofire with this PR took 0.31s vs 0.31s on master (0% slower)
📖 Linting Firefox with this PR took 1.46s vs 1.47s on master (0% faster)
📖 Linting Kickstarter with this PR took 2.18s vs 2.21s on master (1% faster)
📖 Linting Moya with this PR took 0.16s vs 0.16s on master (0% slower)
📖 Linting Nimble with this PR took 0.15s vs 0.15s on master (0% slower)
📖 Linting Quick with this PR took 0.08s vs 0.08s on master (0% slower)
📖 Linting Realm with this PR took 1.09s vs 1.09s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.13s vs 0.13s on master (0% slower)
📖 Linting Sourcery with this PR took 0.5s vs 0.51s on master (1% faster)
📖 Linting Swift with this PR took 0.93s vs 0.94s on master (1% faster)
📖 Linting WordPress with this PR took 2.5s vs 2.49s on master (0% slower)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1020:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1021:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1041:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1042:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1062:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1063:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1083:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1084:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1104:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1105:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:110:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:111:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1128:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1129:100: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1151:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1152:80: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1232:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1237:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1267:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1290:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1295:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:131:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1320:19: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1321:78: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:132:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1346:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:1347:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:155:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:156:100: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:178:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:179:80: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:200:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:201:79: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:281:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:286:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:316:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:339:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:344:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:369:19: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:370:78: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:395:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:396:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:44:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:45:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:488:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:496:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:517:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:525:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:545:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:553:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:573:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:581:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:611:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:619:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:641:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:645:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:666:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:66:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:670:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:67:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:692:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:696:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:783:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:792:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:826:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:849:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:858:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:883:19: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:884:93: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:88:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:89:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:909:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:910:97: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:973:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:974:90: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:998:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Alamofire: /Tests/CombineTests.swift:999:82: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Realm: /Realm/ObjectServerTests/SwiftFlexibleSyncServerTests.swift:1313:15: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Realm: /Realm/ObjectServerTests/SwiftFlexibleSyncServerTests.swift:1316:10: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Realm: /Realm/Tests/SwiftUITestHost/SwiftUITestHostApp.swift:292:25: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Realm: /Realm/Tests/SwiftUITestHost/SwiftUITestHostApp.swift:333:33: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Realm: /Realm/Tests/SwiftUITestHost/SwiftUITestHostApp.swift:339:33: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Parsing/ComposerSpec.swift:515:49: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Parsing/ComposerSpec.swift:539:49: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Parsing/ComposerSpec.swift:563:49: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line. (multiline_arguments_brackets)

Generated by 🚫 Danger

This makes the added test cases work in Xcode 13.2 where the wrapping does not happen.
The call expression is the first substructure in the dictionary, while in Xcode 13.3
it's an argument containing the call expression.
@SimplyDanny SimplyDanny force-pushed the check-examples-on-intel branch from 4dc3ce1 to 943c3a3 Compare June 19, 2022 16:22
@SimplyDanny SimplyDanny changed the title Check that examples work on Intel Look for call expressions which are not wrapped into an argument Jun 19, 2022
@SimplyDanny SimplyDanny marked this pull request as ready for review June 19, 2022 16:37
@SimplyDanny SimplyDanny enabled auto-merge (squash) June 19, 2022 16:38
@SimplyDanny SimplyDanny merged commit 04972a3 into realm:master Jun 19, 2022
@SimplyDanny SimplyDanny deleted the check-examples-on-intel branch June 22, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwiftLint is reporting less violations with Xcode 13.3 than with Xcode 13.2
2 participants