Update documentation for multiline_arguments_brackets and multiline_literal_brackets #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Generated by 🚫 Danger |
SimplyDanny
approved these changes
Aug 17, 2022
…iteral_brackets
- added two triggering examples that are a common style, to make it immediately obvious that they trigger the rules
- also fixed a spelling mistake throughout the examples for the multiline_literal_brackets rule ("Gryffindor" is now correctly spelt)
chrisjf
force-pushed
the
new-trigger-examples
branch
from
bdcf065 to
37a4908
Compare
|
Rebase done ✅ (Although last time I pushed, some of the buildkite phases of the CI failed. I didn't have time to investigate, but if it fails again, I'll take a look, and possibly ask for some pointers if needed.) Thanks for the review. Good night 👋 |
Thank you for offering your help! The build was probably just unstable. I do not expect further issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello SwiftLint Devs 👋
Here are the changes I've made to address the issue #4060 which include:
If more information is needed, please see the description of the issue.
Thanks,
Chris