-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #4788 - when disabled, superfluous_disable_command
should not fire, even for invalid rule identifiers
#4791
Merged
SimplyDanny
merged 5 commits into
realm:main
from
mildm8nnered:mildm8nnered-disable-superfluous-disable-command
Mar 5, 2023
Merged
Fix for #4788 - when disabled, superfluous_disable_command
should not fire, even for invalid rule identifiers
#4791
SimplyDanny
merged 5 commits into
realm:main
from
mildm8nnered:mildm8nnered-disable-superfluous-disable-command
Mar 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah - I just noticed that there are a lot of |
and just saw all the false violations in the open source tests - back to the drawing board :-( |
2 tasks
mildm8nnered
force-pushed
the
mildm8nnered-disable-superfluous-disable-command
branch
from
March 4, 2023 16:55
9aa79f4
to
b0efa7f
Compare
SimplyDanny
approved these changes
Mar 5, 2023
…uld not fire, even for invalid rule identifiers
…ule names, when disabled
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
mildm8nnered
force-pushed
the
mildm8nnered-disable-superfluous-disable-command
branch
from
March 5, 2023 15:50
2fefef5
to
bec39ad
Compare
mildm8nnered
deleted the
mildm8nnered-disable-superfluous-disable-command
branch
April 17, 2023 23:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4788
When
superfluous_disable_command
is disabled, it should not fire, even for invalid rule identifiers.Also fixes #4798 for Aerial - see the
This PR fixed a violation in Aerial
messages below, but only accidentally. See #4799 for more details, and a proper fix for #4798