Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #4788 - when disabled, superfluous_disable_command should not fire, even for invalid rule identifiers #4791

Conversation

mildm8nnered
Copy link
Collaborator

@mildm8nnered mildm8nnered commented Mar 1, 2023

Fixes #4788

When superfluous_disable_command is disabled, it should not fire, even for invalid rule identifiers.

Also fixes #4798 for Aerial - see the This PR fixed a violation in Aerial messages below, but only accidentally. See #4799 for more details, and a proper fix for #4798

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 1, 2023

203 Messages
📖 Linting Aerial with this PR took 1.07s vs 1.06s on main (0% slower)
📖 Linting Alamofire with this PR took 1.36s vs 1.38s on main (1% faster)
📖 Linting Brave with this PR took 7.45s vs 7.44s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 3.18s vs 3.18s on main (0% slower)
📖 Linting Firefox with this PR took 9.29s vs 9.34s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.33s vs 10.28s on main (0% slower)
📖 Linting Moya with this PR took 0.54s vs 0.53s on main (1% slower)
📖 Linting NetNewsWire with this PR took 3.1s vs 3.11s on main (0% faster)
📖 Linting Nimble with this PR took 0.6s vs 0.6s on main (0% slower)
📖 Linting PocketCasts with this PR took 7.24s vs 7.24s on main (0% slower)
📖 Linting Quick with this PR took 0.23s vs 0.23s on main (0% slower)
📖 Linting Realm with this PR took 11.54s vs 11.56s on main (0% faster)
📖 Linting SourceKitten with this PR took 0.44s vs 0.44s on main (0% slower)
📖 Linting Sourcery with this PR took 2.23s vs 2.21s on main (0% slower)
📖 Linting Swift with this PR took 4.83s vs 4.83s on main (0% slower)
📖 Linting VLC with this PR took 1.36s vs 1.37s on main (0% faster)
📖 Linting Wire with this PR took 8.43s vs 8.42s on main (0% slower)
📖 Linting WordPress with this PR took 11.26s vs 11.27s on main (0% faster)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!$0.isAvailableOffline' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!(hasFavs' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!PrefsVideos.favorites.contains($0.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!PrefsVideos.hidden.contains($0.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!hasUnfavs)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!videos.filter({!$0.isAvailableOffline}).isEmpty' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!videos.filter({' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '!videos.isEmpty' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '""' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '":")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '":")[1])!' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"Cache' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"Favorite' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"Hide' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"Reset' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"Show' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"Unfavorite' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '"videos:")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '#selector(cacheMissingVideos(_:)),' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '#selector(favoriteVideos(_:)),' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '#selector(hideVideos(_:)),' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '#selector(resetVibrance(_:)),' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '#selector(showVideos(_:)),' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '#selector(unfavoriteVideos(_:)),' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '$0.secondaryName' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '$1.secondaryName' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '&&' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '->' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '.hidden' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '//' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '<' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '=' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '==' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '?' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '@objc' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Add' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Add/remove' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Any)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Cache.ensureDownload' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Do' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Don't' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Grab' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'I' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Int(path.split(separator:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Make' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'NSMenu()' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'NSMenu?' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'NSMenuItem(title:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'NSOutlineView,' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Oh' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.favorites.append(video.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.favorites.contains($0.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.favorites.firstIndex(of:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.favorites.remove(at:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.hidden.append(video.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.hidden.contains($0.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.hidden.firstIndex(of:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.hidden.remove(at:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.vibrance.keys.contains($0.id)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'PrefsVideos.vibrance.removeValue(forKey:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Sidebar.MenuEntry' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Sidebar.instance.refreshVideos()' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Store' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'String(entry.path[idx!…].dropFirst())' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'Swift…' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'VideoList.instance.getVideosForPath(self.menuPath)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'VideoList.instance.getVideosForSource(index,' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'VideoList.instance.modeFromPath(path)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'VideoList.instance.videos.sorted' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'VideoManager.sharedInstance.queueDownload(video)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'We' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: '[AerialVideo]' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'a' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'action:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'as?' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'byExtendingSelection:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'cache' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'cacheMissingVideos(_' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'category' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'click' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'clicking' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'debugLog("empty' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'else' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'entry' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'entry.path.firstIndex(of:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'entry.path.starts(with:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'errorLog("Right' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'expandChildren:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'false' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'false)' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'favoriteVideos(_' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'favorites' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'favs' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'for' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'func' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'guard' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'hasFavs' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'hasUnfavs' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'have' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'here' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'hidden' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'hide' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'hideVideos(_' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'idx' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'if' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'in' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'index' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'it' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'it's' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item.setIcons("arrow.down.circle")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item.setIcons("eye")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item.setIcons("eye.slash")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item.setIcons("slider.horizontal.3")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item.setIcons("star")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item.setIcons("star.fill")' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'item:' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:430:4: warning: Superfluous Disable Command Violation: 'just' is not a valid SwiftLint rule; remove it from the disable command (superfluous_disable_command)
⚠️ Danger found 203 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 137.

Generated by 🚫 Danger

@mildm8nnered
Copy link
Collaborator Author

Ah - I just noticed that there are a lot of testSuperfluousDisableCommandsXXX in CommandTests - I'll look at moving my tests there as well

@mildm8nnered
Copy link
Collaborator Author

and just saw all the false violations in the open source tests - back to the drawing board :-(

@mildm8nnered mildm8nnered force-pushed the mildm8nnered-disable-superfluous-disable-command branch from 2fefef5 to bec39ad Compare March 5, 2023 15:50
@SimplyDanny SimplyDanny merged commit 228d537 into realm:main Mar 5, 2023
@mildm8nnered mildm8nnered deleted the mildm8nnered-disable-superfluous-disable-command branch April 17, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants