Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new --silence-deprecation-warnings flag #5014

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #4989.

Not sure if I like this. Yet, it was easy to implement after refactoring the issue reporting.

@SimplyDanny SimplyDanny requested a review from jpsim May 16, 2023 19:50
@SwiftLintBot
Copy link

SwiftLintBot commented May 16, 2023

17 Messages
📖 Linting Aerial with this PR took 1.11s vs 1.11s on main (0% slower)
📖 Linting Alamofire with this PR took 1.41s vs 1.41s on main (0% slower)
📖 Linting Brave with this PR took 7.84s vs 7.88s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 3.83s vs 3.84s on main (0% faster)
📖 Linting Firefox with this PR took 9.81s vs 9.84s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.21s vs 10.26s on main (0% faster)
📖 Linting Moya with this PR took 0.58s vs 0.6s on main (3% faster)
📖 Linting NetNewsWire with this PR took 3.23s vs 3.24s on main (0% faster)
📖 Linting Nimble with this PR took 0.67s vs 0.67s on main (0% slower)
📖 Linting PocketCasts with this PR took 7.69s vs 7.74s on main (0% faster)
📖 Linting Quick with this PR took 0.34s vs 0.34s on main (0% slower)
📖 Linting Realm with this PR took 11.12s vs 11.17s on main (0% faster)
📖 Linting Sourcery with this PR took 2.27s vs 2.26s on main (0% slower)
📖 Linting Swift with this PR took 5.05s vs 5.07s on main (0% faster)
📖 Linting VLC with this PR took 1.37s vs 1.37s on main (0% slower)
📖 Linting Wire with this PR took 8.46s vs 8.46s on main (0% slower)
📖 Linting WordPress with this PR took 11.94s vs 11.96s on main (0% faster)

Generated by 🚫 Danger

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with having this flag at a high level, and ok with the implementation, considering that the alternative would be significantly more invasive.

@SimplyDanny SimplyDanny enabled auto-merge (squash) June 20, 2023 19:43
@SimplyDanny SimplyDanny changed the title Add new --quiet-deprecation-warnings flag to silence deprecation warnings Add new --silence-deprecation-warnings flag Jun 20, 2023
@SimplyDanny SimplyDanny merged commit 41b0662 into realm:main Jun 20, 2023
@@ -25,6 +25,11 @@
(e.g. `@testable`, `@_exported`, ...).
[hiltonc](https://github.com/hiltonc)

* Add new `--quiet-deprecation-warnings` flag that silences deprecation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh bummer! Thank you for the prompt correction.

@SimplyDanny SimplyDanny deleted the quiet-deprecation-warnings branch June 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings for deprecated rules that are implicitly enabled using the all rule
3 participants