-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new --silence-deprecation-warnings
flag
#5014
Add new --silence-deprecation-warnings
flag
#5014
Conversation
Generated by 🚫 Danger |
580e858
to
18ebd11
Compare
18ebd11
to
b85775b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with having this flag at a high level, and ok with the implementation, considering that the alternative would be significantly more invasive.
b85775b
to
25c8501
Compare
--quiet-deprecation-warnings
flag to silence deprecation warnings--silence-deprecation-warnings
flag
@@ -25,6 +25,11 @@ | |||
(e.g. `@testable`, `@_exported`, ...). | |||
[hiltonc](https://github.com/hiltonc) | |||
|
|||
* Add new `--quiet-deprecation-warnings` flag that silences deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh bummer! Thank you for the prompt correction.
Fixes #4989.
Not sure if I like this. Yet, it was easy to implement after refactoring the issue reporting.