Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only configuration option to todo rule #5233

Merged
merged 11 commits into from
Sep 26, 2023

Conversation

gibachan
Copy link
Contributor

Resolves #5232

This PR adds an only configuration option to the todo rule.
This option allows you to choose whether only FIXME or TODO will be warned.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 23, 2023

17 Messages
📖 Linting Aerial with this PR took 1.19s vs 1.2s on main (0% faster)
📖 Linting Alamofire with this PR took 1.56s vs 1.56s on main (0% slower)
📖 Linting Brave with this PR took 8.92s vs 8.92s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.45s vs 4.44s on main (0% slower)
📖 Linting Firefox with this PR took 10.38s vs 10.38s on main (0% slower)
📖 Linting Kickstarter with this PR took 11.49s vs 11.49s on main (0% slower)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.35s vs 3.36s on main (0% faster)
📖 Linting Nimble with this PR took 0.83s vs 0.83s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.83s vs 8.83s on main (0% slower)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 11.73s vs 11.72s on main (0% slower)
📖 Linting Sourcery with this PR took 2.83s vs 2.85s on main (0% faster)
📖 Linting Swift with this PR took 5.28s vs 5.28s on main (0% slower)
📖 Linting VLC with this PR took 1.55s vs 1.54s on main (0% slower)
📖 Linting Wire with this PR took 9.13s vs 9.12s on main (0% slower)
📖 Linting WordPress with this PR took 13.26s vs 13.27s on main (0% faster)

Generated by 🚫 Danger

@gibachan gibachan changed the title Add only configuration to todo rule Add only configuration option to todo rule Sep 23, 2023
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up!

@SimplyDanny
Copy link
Collaborator

Rebased, renamed property and moved changelog entry to new main section.

@SimplyDanny SimplyDanny enabled auto-merge (squash) September 26, 2023 18:24
@SimplyDanny SimplyDanny merged commit 1bbce6c into realm:main Sep 26, 2023
4 checks passed
@grantneufeld
Copy link

Just a word of thanks, to both of you @gibachan and @SimplyDanny , for the speedy implementation of this requested feature. 💚

KS1019 pushed a commit to KS1019/SwiftLint that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Request: [todo] Extend todo rule to allow FIXME and TODO be separately chosen
4 participants