-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add only
configuration option to todo
rule
#5233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
gibachan
changed the title
Add
Add Sep 23, 2023
only
configuration to todo
ruleonly
configuration option to todo
rule
SimplyDanny
requested changes
Sep 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this up!
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TodoConfiguration.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
reviewed
Sep 25, 2023
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TodoConfiguration.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
reviewed
Sep 25, 2023
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TodoConfiguration.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TodoConfiguration.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
force-pushed
the
todo_configuration
branch
from
September 26, 2023 18:20
985918b
to
0f83da7
Compare
Rebased, renamed property and moved changelog entry to new |
SimplyDanny
approved these changes
Sep 26, 2023
Just a word of thanks, to both of you @gibachan and @SimplyDanny , for the speedy implementation of this requested feature. 💚 |
KS1019
pushed a commit
to KS1019/SwiftLint
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5232
This PR adds an
only
configuration option to thetodo
rule.This option allows you to choose whether only FIXME or TODO will be warned.