Preserve @_exported import statements in unused_imports
#5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing downstream modules depending on the re-exported module.
jszumski
commented
Sep 27, 2023
| @@ -122,7 +125,7 @@ struct UnusedImportRuleExamples { | |||
| dispatchMain() | |||
| """), | |||
| Example(""" | |||
| ↓@_exported import Foundation | |||
| ↓@_implementationOnly import Foundation | |||
There was a problem hiding this comment.
The original intent in #2993 seemed to make sure any attributed import was correctable, so I arbitrarily chose @_implementationOnly as a replacement.
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve
@_exportedimport statements even if unused to avoid breaking downstream modules depending on the re-exported module.