Expand usage of "config" to "configuration" in most places #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2016
Merged
|
Maybe we should use custom_rules:
config_abbreviation:
name: "config abbreviation"
regex: "[cC][oO][nN][fF][iI][gG][^uU]"
match_kinds:
- identifier
message: "config should be disabbreviated!"
severity: error |
|
Haha. Love it. 😄 |
with an exception being made for the "use_nested_configs" configuration key, since that's already long enough as it is
jpsim
force-pushed
the
jp-expand-config
branch
from
8cf78e7 to
2f24e1d
Compare
|
rules for all the things! 😛 |
|
Merging in #527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a considerable impact on the public API and touches a large part of the codebase. We decided to do this in #507 (which this PR depends on).
There are two places where we still use the "config" abbreviation: the command line
--configparameter and theuse_nested_configsconfiguration key. I'd actually suggest that we deprecate the configuration key altogether since when would you ever have nested configuration files without wanting to use them? This should just be the standard behavior IMO./cc @scottrhoyt @norio-nomura