Rewrite cyclomatic_complexity with SwiftSyntax #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
I've looked into the only change oss-check is reporting and I think this PR is actually fixing a bug. Looks like the old implementation could end up excluding |
marcelofabri
commented
Oct 29, 2023
|
|
||
| // Switch complexity is reduced by `fallthrough` cases | ||
| override func visitPost(_ node: CatchClauseSyntax) { |
There was a problem hiding this comment.
this is a bit weird, and maybe not intentional but this snippet:
do {} catch {}contains a case according to SourceKitten:
{
"key.diagnostic_stage" : "source.diagnostic.stage.swift.parse",
"key.length" : 14,
"key.offset" : 0,
"key.substructure" : [
{
"key.bodylength" : 0,
"key.bodyoffset" : 4,
"key.kind" : "source.lang.swift.stmt.brace",
"key.length" : 2,
"key.offset" : 3
},
{
"key.elements" : [
{
"key.kind" : "source.lang.swift.structure.elem.pattern",
"key.length" : 1,
"key.offset" : 12
}
],
"key.kind" : "source.lang.swift.stmt.case",
"key.length" : 8,
"key.offset" : 6
}
]
}since it's kind of a different branch I decided to keep counting it.
There was a problem hiding this comment.
The fact that SourceKit thinks that's a case statement is weird, but it's true that there are two branches in do {} catch {}: one where only do is invoked and another where do and catch are invoked.
jpsim
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.