Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite void_return rule with SwiftSyntax #5351

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Rewrite void_return rule with SwiftSyntax #5351

merged 1 commit into from
Nov 15, 2023

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR may need tests.
16 Messages
📖 Linting Aerial with this PR took 0.16s vs 0.26s on main (38% faster)
📖 Linting Alamofire with this PR took 0.12s vs 0.29s on main (58% faster)
📖 Linting Brave with this PR took 0.54s vs 1.7s on main (68% faster)
📖 Linting DuckDuckGo with this PR took 0.38s vs 0.91s on main (58% faster)
📖 Linting Firefox with this PR took 0.53s vs 1.63s on main (67% faster)
📖 Linting Kickstarter with this PR took 0.58s vs 1.8s on main (67% faster)
📖 Linting Moya with this PR took 0.14s vs 0.17s on main (17% faster)
📖 Linting NetNewsWire with this PR took 0.22s vs 0.64s on main (65% faster)
📖 Linting Nimble with this PR took 0.12s vs 0.22s on main (45% faster)
📖 Linting PocketCasts with this PR took 0.51s vs 1.54s on main (66% faster)
📖 Linting Quick with this PR took 0.09s vs 0.13s on main (30% faster)
📖 Linting Realm with this PR took 0.45s vs 1.05s on main (57% faster)
📖 Linting Sourcery with this PR took 0.25s vs 0.52s on main (51% faster)
📖 Linting VLC with this PR took 0.15s vs 0.33s on main (54% faster)
📖 Linting Wire with this PR took 1.07s vs 3.8s on main (71% faster)
📖 Linting WordPress with this PR took 0.8s vs 2.56s on main (68% faster)

Generated by 🚫 Danger

jpsim
jpsim approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Textbook example of migrating a messy rule to a clean SwiftSyntax implementation 👌

@SimplyDanny SimplyDanny merged commit 9fbc04e into realm:main Nov 15, 2023
4 checks passed
@SimplyDanny SimplyDanny deleted the rewrite-void-return branch November 15, 2023 06:13
@SimplyDanny SimplyDanny mentioned this pull request Dec 9, 2023
Closed
u-abyss pushed a commit to u-abyss/SwiftLint that referenced this pull request Dec 16, 2023
@SimplyDanny @u-abyss
Rewrite void_return rule with SwiftSyntax (realm#5351)
bf402db
MartijnAmbagtsheer pushed a commit to MartijnAmbagtsheer/SwiftLint that referenced this pull request Dec 20, 2023
@SimplyDanny
Rewrite void_return rule with SwiftSyntax (realm#5351)
abe277d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimplyDanny @SwiftLintBot @jpsim