Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore functions with default parameters in unneeded_override rule #5356

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented Nov 16, 2023

Fixes #5355.

@SwiftLintBot
Copy link

17 Messages
📖 Linting Aerial with this PR took 1.24s vs 1.2s on main (3% slower)
📖 Linting Alamofire with this PR took 1.56s vs 1.56s on main (0% slower)
📖 Linting Brave with this PR took 9.04s vs 9.12s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 4.6s vs 4.61s on main (0% faster)
📖 Linting Firefox with this PR took 10.52s vs 10.47s on main (0% slower)
📖 Linting Kickstarter with this PR took 11.04s vs 11.0s on main (0% slower)
📖 Linting Moya with this PR took 0.61s vs 0.62s on main (1% faster)
📖 Linting NetNewsWire with this PR took 3.28s vs 3.27s on main (0% slower)
📖 Linting Nimble with this PR took 0.82s vs 0.82s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.89s vs 8.9s on main (0% faster)
📖 Linting Quick with this PR took 0.4s vs 0.39s on main (2% slower)
📖 Linting Realm with this PR took 11.47s vs 11.47s on main (0% slower)
📖 Linting Sourcery with this PR took 2.82s vs 2.85s on main (1% faster)
📖 Linting VLC with this PR took 1.56s vs 1.59s on main (1% faster)
📖 Linting Wire with this PR took 19.69s vs 19.68s on main (0% slower)
📖 Linting WordPress with this PR took 13.41s vs 13.46s on main (0% faster)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/ButtonToast.swift:144:3: warning: Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit 9cd4740 into realm:main Nov 16, 2023
4 checks passed
@SimplyDanny SimplyDanny deleted the unneeded-override branch November 16, 2023 21:44
u-abyss pushed a commit to u-abyss/SwiftLint that referenced this pull request Dec 16, 2023
MartijnAmbagtsheer pushed a commit to MartijnAmbagtsheer/SwiftLint that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in unneeded_override
2 participants