RedundantTypeAnnotationRule: Rewrite with SwiftSyntax and allow ignoring certain attributes#5389

Merged

SimplyDanny merged 35 commits intorealm:mainfrom tonell-m:feature/add-attributes-ignore-config-to-redundanttypeannoations

Apr 21, 2024

+208-78

Commits on Apr 21, 2024

Rewrite RedundantTypeAnnotationRule using SwiftSyntax

tonell_m
authored and
SimplyDanny
committed
Add the possibility to ignore properties marked with configurable attributes

tonell_m
authored and
SimplyDanny
committed
Finetune implementation so that all tests pass

tonell_m
authored and
SimplyDanny
committed
Fix configuration key to match property name

tonell_m
authored and
SimplyDanny
committed
Only flag Bool literal initializer as a redundancy

tonell_m
authored and
SimplyDanny
committed
Break down line with too much characters

tonell_m
authored and
SimplyDanny
committed
Take generic arguments into account when comparing types

tonell_m
authored and
SimplyDanny
committed
Fix linting errors

tonell_m
authored and
SimplyDanny
committed
Add changelog entry

tonell_m
authored and
SimplyDanny
committed
Add support of function call initializers that are member access expressions

tonell_m
authored and
SimplyDanny
committed
Add some extra examples for edge cases testing

tonell_m
authored and
SimplyDanny
committed
Add handling of force unwrapped initializers

tonell_m
authored and
SimplyDanny
committed
Remove trailing comma

tonell_m
authored and
SimplyDanny
committed
Update changelog to only mention the new option

tonell_m
authored and
SimplyDanny
committed
Use @SwiftSyntaxRule and remove explicit makeVisitor implementation

tonell_m
authored and
SimplyDanny
committed
Move description back to the main class

tonell_m
authored and
SimplyDanny
committed
Use binding nodes instead of variable declarations to avoid handling edge cases manually

tonell_m
authored and
SimplyDanny
committed
Add a more in depth handling of generics

tonell_m
authored and
SimplyDanny
committed
Rename ignored_annotations to ignore_attributes

tonell_m
authored and
SimplyDanny
committed
Fix linter issues

tonell_m
authored and
SimplyDanny
committed
Use PatternBindingSyntax parent's parent to check for attributes

tonell_m
authored and
SimplyDanny
committed
Add tests for ignore_attributes configuration

tonell_m
authored and
SimplyDanny
committed
Use ExprSyntax as node type for isMemberAccess

tonell_m
authored and
SimplyDanny
committed
Add credit in changelog for rewriting rule with SwiftSyntax

tonell_m
authored and
SimplyDanny
committed
Fixed incorrect syntax in Examples

tonell_m
authored and
SimplyDanny
committed
Removed unused configuration parameters

tonell_m
authored and
SimplyDanny
committed
Changelog tweaks

tonell_m
authored and
SimplyDanny
committed
Added two spaces in Changelog to ensure linebreak

tonell_m
authored and
SimplyDanny
committed
Handle chained MemberAccessExprSyntax in variable declarations

tonell_m
authored and
SimplyDanny
committed
Adapt to current state of code base
SimplyDanny
committed
Support function calls in the access chain
SimplyDanny
committed
Let visitor define corrections
SimplyDanny
committed
Use if instead of guard
SimplyDanny
committed
Fix changelog
SimplyDanny
committed
Add new attribute to test reference
SimplyDanny
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RedundantTypeAnnotationRule: Rewrite with SwiftSyntax and allow ignoring certain attributes#5389

Commits on Apr 21, 2024

Rewrite RedundantTypeAnnotationRule using SwiftSyntax

Add the possibility to ignore properties marked with configurable attributes

Finetune implementation so that all tests pass

Fix configuration key to match property name

Only flag Bool literal initializer as a redundancy

Break down line with too much characters

Take generic arguments into account when comparing types

Fix linting errors

Add changelog entry

Add support of function call initializers that are member access expressions

Add some extra examples for edge cases testing

Add handling of force unwrapped initializers

Remove trailing comma

Update changelog to only mention the new option

Use @SwiftSyntaxRule and remove explicit makeVisitor implementation

Move description back to the main class

Use binding nodes instead of variable declarations to avoid handling edge cases manually

Add a more in depth handling of generics

Rename ignored_annotations to ignore_attributes

Fix linter issues

Use PatternBindingSyntax parent's parent to check for attributes

Add tests for ignore_attributes configuration

Use ExprSyntax as node type for isMemberAccess

Add credit in changelog for rewriting rule with SwiftSyntax

Fixed incorrect syntax in Examples

Removed unused configuration parameters

Changelog tweaks

Added two spaces in Changelog to ensure linebreak

Handle chained MemberAccessExprSyntax in variable declarations

Adapt to current state of code base

Support function calls in the access chain

Let visitor define corrections

Use `if` instead of `guard`

Fix changelog

Add new attribute to test reference