Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new shorthand_argument rule #5451

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Happy to contribute the oldest requested rule that has not yet been implemented! 🎉

Resolves #70.

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 3, 2024

219 Warnings
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift:629:29: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Playlist/VideoPlayer/UI/VideoPlayer.swift:559:31: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Playlist/VideoPlayer/UI/VideoPlayer.swift:561:38: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Reader/ReaderModeStyleViewController.swift:136:36: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Settings/Debug/AdblockDebugMenuTableViewController.swift:126:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Settings/Debug/AdblockDebugMenuTableViewController.swift:138:10: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Widgets/TwoLineCell.swift:311:14: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveUI/SwiftUI/ResetListStyleModifier.swift:26:18: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveUI/UIKit/AlertPopupView.swift:75:34: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveVPN/VPNProductInfo.swift:66:43: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/FiltersDisplaySettingsView.swift:611:11: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/Portfolio/PortfolioSegmentedControl.swift:87:11: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/WalletDisclosureGroup.swift:33:9: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/WalletDisclosureGroup.swift:63:11: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/WalletDisclosureGroup.swift:66:9: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:380:28: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Tests/BraveSharedTests/NSURLExtensionsTests.swift:377:42: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Tests/BraveSharedTests/NSURLExtensionsTests.swift:386:42: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Tests/BraveSharedTests/NSURLExtensionsTests.swift:408:42: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Tests/BraveSharedTests/NSURLExtensionsTests.swift:417:42: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Brave: /Tests/BraveWalletTests/AssetDetailStoreTests.swift:458:24: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/KeychainItemsDebugViewController.swift:117:37: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/KeychainItemsDebugViewController.swift:118:40: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/KeychainItemsDebugViewController.swift:119:44: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Client/Utils/SearchTermGroupsUtility.swift:250:39: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Client/Utils/SearchTermGroupsUtility.swift:250:69: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Client/Utils/SearchTermGroupsUtility.swift:254:44: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Client/Utils/SearchTermGroupsUtility.swift:254:91: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewControllerTests.swift:27:40: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewControllerTests.swift:28:43: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewControllerTests.swift:28:48: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewControllerTests.swift:81:40: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewControllerTests.swift:82:43: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Search/Controller/SearchViewControllerTests.swift:82:48: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:113:26: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:139:22: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:165:21: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:191:13: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:217:21: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:244:24: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:268:23: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:295:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:321:25: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:347:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:373:17: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:399:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:425:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:451:25: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/BackingLenses.swift:477:17: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/CountryLenses.swift:24:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/DiscoveryParamsLenses.swift:142:15: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/DiscoveryParamsLenses.swift:152:36: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/DiscoveryParamsLenses.swift:162:60: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/DiscoveryParamsLenses.swift:172:64: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/GraphCategoryLenses.swift:65:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/GraphCategoryLenses.swift:82:24: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/GraphCategoryLenses.swift:96:28: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/Project.StatsLenses.swift:15:22: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:167:75: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:184:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:216:38: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:232:64: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:248:91: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:265:29: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:281:64: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:297:99: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:315:58: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:333:41: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:349:58: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:365:74: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:381:89: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:397:105: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:414:40: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/ProjectLenses.swift:62:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:133:30: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:158:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:183:13: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:208:16: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:233:25: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:258:18: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:283:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:308:23: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:333:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:358:24: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:383:32: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:408:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:433:16: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/RewardLenses.swift:50:22: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:110:16: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:127:21: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:144:17: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:161:16: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:76:16: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:93:17: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NotificationsLenses.swift:155:66: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NotificationsLenses.swift:168:107: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NotificationsLenses.swift:182:61: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NotificationsLenses.swift:195:96: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NotificationsLenses.swift:209:53: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.NotificationsLenses.swift:222:76: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/User.StatsLenses.swift:64:31: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:111:18: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:136:26: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:161:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:186:20: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:211:19: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:236:15: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:262:34: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:289:22: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:315:24: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:341:36: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:367:28: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:393:17: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:419:16: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/models/lenses/UserLenses.swift:443:47: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Library/Format.swift:597:17: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Library/Format.swift:608:44: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectUpdatesViewModel.swift:108:32: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/ProjectUpdatesViewModel.swift:109:32: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Private/API Tasks/UploadFilesUpdateTask.swift:59:24: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/BookmarkManager.swift:65:46: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/End of Year/StoriesModel.swift:146:21: warning: Shorthand Argument Violation: References to shorthand arguments too far away from the closure's beginning should be avoided (shorthand_argument)
⚠️ Danger found 219 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 122.
17 Messages
📖 Linting Aerial with this PR took 0.73s vs 0.74s on main (1% faster)
📖 Linting Alamofire with this PR took 1.03s vs 1.02s on main (0% slower)
📖 Linting Brave with this PR took 5.85s vs 5.87s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 3.04s vs 3.03s on main (0% slower)
📖 Linting Firefox with this PR took 7.78s vs 7.78s on main (0% slower)
📖 Linting Kickstarter with this PR took 7.07s vs 7.06s on main (0% slower)
📖 Linting Moya with this PR took 0.43s vs 0.44s on main (2% faster)
📖 Linting NetNewsWire with this PR took 2.07s vs 2.07s on main (0% slower)
📖 Linting Nimble with this PR took 0.61s vs 0.6s on main (1% slower)
📖 Linting PocketCasts with this PR took 5.74s vs 5.8s on main (1% faster)
📖 Linting Quick with this PR took 0.29s vs 0.29s on main (0% slower)
📖 Linting Realm with this PR took 3.65s vs 3.62s on main (0% slower)
📖 Linting Sourcery with this PR took 1.76s vs 1.76s on main (0% slower)
📖 Linting Swift with this PR took 3.47s vs 3.42s on main (1% slower)
📖 Linting VLC with this PR took 0.99s vs 0.98s on main (1% slower)
📖 Linting Wire with this PR took 12.32s vs 12.39s on main (0% faster)
📖 Linting WordPress with this PR took 8.24s vs 8.2s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the shorthand-argument-rule branch 5 times, most recently from af7f1c0 to e035ab9 Compare February 6, 2024 22:26
@SimplyDanny SimplyDanny enabled auto-merge (squash) February 6, 2024 23:33
@SimplyDanny SimplyDanny merged commit 7c29ae4 into realm:main Feb 6, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the shorthand-argument-rule branch February 7, 2024 20:34
kohtenko pushed a commit to kohtenko/SwiftLint that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate use of $0 only if it's "simple"
2 participants