-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new static_over_final_class
rule
#5487
Conversation
04c2b15
to
1b189e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. A few remarks ...
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Run |
1b189e0
to
4aa6ada
Compare
final_class
rulestatic_over_final_class
rule
@SimplyDanny thanks for the review! I have pushed changes to address all comments, and also noted a question here if you have time to explain your approach to me. If you are happy with the contents of the PR, I will squash the commits and update the PR to clean up the history. |
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Manual squashing is not necessary. That's done by GitHub when merging. |
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
Implements rule requested in #5471