Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new static_over_final_class rule #5487

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

phlippieb
Copy link
Contributor

Implements rule requested in #5471

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 6, 2024

212 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:101:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:65:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/BlockedResource.swift:338:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/BraveVPNAlert.swift:232:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/CustomFilterListSetting.swift:17:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/CustomFilterListSetting.swift:22:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/CustomFilterListSetting.swift:41:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/CustomFilterListSetting.swift:54:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/DataSaved.swift:15:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/DataSaved.swift:19:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/DataSaved.swift:23:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/DataSaved.swift:31:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/DataSaved.swift:45:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/DataSaved.swift:49:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:106:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:120:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:129:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:135:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:167:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:175:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:183:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:191:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:201:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:218:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Domain.swift:254:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:100:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:105:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:109:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:126:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:140:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:49:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:57:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/Favorite.swift:94:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:13:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:17:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:21:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:25:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:33:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:37:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:41:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:46:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:56:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FeedSourceOverride.swift:65:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FilterListSetting.swift:37:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FilterListSetting.swift:42:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FilterListSetting.swift:66:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/FilterListSetting.swift:71:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistFolder.swift:190:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistFolder.swift:29:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistItem.swift:223:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistItem.swift:408:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistItem.swift:61:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistItem.swift:76:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/PlaylistItem.swift:97:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:13:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:17:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:21:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:31:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:41:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:49:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RSSFeedSource.swift:54:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentSearches.swift:117:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentSearches.swift:24:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentSearches.swift:94:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:34:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:38:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:43:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:55:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:59:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:74:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:85:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Brave: /Sources/Data/models/RecentlyClosed.swift:89:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BrowsingMenu/BrowsingMenuAnimator.swift:125:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BrowsingMenu/BrowsingMenuViewController.swift:141:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BrowsingMenu/BrowsingMenuViewController.swift:63:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/NetworkProtectionStatusViewModel.swift:218:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/NetworkProtectionStatusViewModel.swift:222:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Home/PrivateHomepageViewControllerTests.swift:10:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Kickstarter: /Library/DataSource/UIView-Extensions.swift:36:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Kickstarter: /Library/GradientView.swift:5:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Kickstarter: /Library/UIViewController-Preparation.swift:40:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Defaults.swift:15:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Defaults.swift:28:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Defaults.swift:5:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider.swift:183:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider.swift:186:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider.swift:189:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Account.swift:1000:2: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:260:2: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in NetNewsWire: /Account/Sources/Account/NewsBlur/NewsBlurAccountDelegate.swift:615:2: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in NetNewsWire: /Mac/Inspector/InspectorWindowController.swift:25:2: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Sources/Quick/Filter.swift:29:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Sources/Quick/Filter.swift:37:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Tests/QuickTests/QuickTests/FunctionalTests/Async/ItAsyncTests.swift:143:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Tests/QuickTests/QuickTests/FunctionalTests/Async/ItAsyncTests.swift:150:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Tests/QuickTests/QuickTests/FunctionalTests/ItTests.swift:143:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Tests/QuickTests/QuickTests/FunctionalTests/ItTests.swift:150:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Quick: /Tests/QuickTests/QuickTests/FunctionalTests/SubclassDetectionSpec.swift:12:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/AsymmetricObject.swift:84:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/EmbeddedObject.swift:117:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/EmbeddedObject.swift:61:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/List.swift:211:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/List.swift:225:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Map.swift:747:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Map.swift:758:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/MutableSet.swift:189:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/MutableSet.swift:200:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Object.swift:136:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Object.swift:727:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Object.swift:731:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Realm: /RealmSwift/ObjectId.swift:43:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift:282:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift:449:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift:861:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ManagedBuffer.swift:71:3: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Source/Model/Message/LocationData.swift:28:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Source/Notifications/ObjectObserverTokens/Helpers/StringKeyPath.swift:29:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Tests/Source/Model/Messages/ZMClientMessageTests.swift:24:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Tests/Source/Model/Messages/ZMClientMessageTests.swift:31:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Tests/Source/Model/UserClient/UserClientTests.swift:28:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Tests/Source/Model/UserClient/UserClientTests.swift:35:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-request-strategy/Sources/Request Strategies/Assets/Helpers/LinkAttachmentsPreprocessor.swift:27:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-request-strategy/Sources/Request Strategies/Assets/Helpers/LinkAttachmentsPreprocessor.swift:31:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-request-strategy/Sources/Request Strategies/Assets/Helpers/LinkAttachmentsPreprocessor.swift:35:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ This PR introduced a violation in Wire: /wire-ios-request-strategy/Sources/Request Strategies/Assets/Helpers/LinkAttachmentsPreprocessor.swift:39:5: warning: Static Over Final Class Violation: Prefer static over final class for non-overridable declarations (static_over_final_class)
⚠️ Danger found 212 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 125.
17 Messages
📖 Linting Aerial with this PR took 0.73s vs 0.73s on main (0% slower)
📖 Linting Alamofire with this PR took 1.03s vs 1.03s on main (0% slower)
📖 Linting Brave with this PR took 5.91s vs 5.89s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 3.15s vs 3.13s on main (0% slower)
📖 Linting Firefox with this PR took 8.73s vs 8.64s on main (1% slower)
📖 Linting Kickstarter with this PR took 7.14s vs 7.23s on main (1% faster)
📖 Linting Moya with this PR took 0.43s vs 0.43s on main (0% slower)
📖 Linting NetNewsWire with this PR took 1.95s vs 1.95s on main (0% slower)
📖 Linting Nimble with this PR took 0.61s vs 0.61s on main (0% slower)
📖 Linting PocketCasts with this PR took 6.13s vs 6.11s on main (0% slower)
📖 Linting Quick with this PR took 0.3s vs 0.3s on main (0% slower)
📖 Linting Realm with this PR took 3.65s vs 3.61s on main (1% slower)
📖 Linting Sourcery with this PR took 1.81s vs 1.82s on main (0% faster)
📖 Linting Swift with this PR took 3.5s vs 3.46s on main (1% slower)
📖 Linting VLC with this PR took 0.99s vs 0.99s on main (0% slower)
📖 Linting Wire with this PR took 12.85s vs 12.83s on main (0% slower)
📖 Linting WordPress with this PR took 8.44s vs 8.42s on main (0% slower)

Generated by 🚫 Danger

@phlippieb phlippieb force-pushed the feature/final-class-rule branch from 04c2b15 to 1b189e0 Compare March 6, 2024 12:01
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. A few remarks ...

@SimplyDanny
Copy link
Collaborator

Run IntegrationTests locally to get rid of the build failures. Also exclude the new rule from the .swiftlint.yml file.

@phlippieb phlippieb force-pushed the feature/final-class-rule branch from 1b189e0 to 4aa6ada Compare March 7, 2024 08:06
@phlippieb phlippieb changed the title Add new final_class rule Add new static_over_final_class rule Mar 7, 2024
@phlippieb
Copy link
Contributor Author

phlippieb commented Mar 7, 2024

@SimplyDanny thanks for the review! I have pushed changes to address all comments, and also noted a question here if you have time to explain your approach to me.

If you are happy with the contents of the PR, I will squash the commits and update the PR to clean up the history.

@phlippieb phlippieb requested a review from SimplyDanny March 7, 2024 11:01
@SimplyDanny
Copy link
Collaborator

If you are happy with the contents of the PR, I will squash the commits and update the PR to clean up the history.

Manual squashing is not necessary. That's done by GitHub when merging.

phlippieb and others added 2 commits March 8, 2024 11:27
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
@phlippieb phlippieb requested a review from SimplyDanny March 8, 2024 10:02
@SimplyDanny SimplyDanny linked an issue Mar 8, 2024 that may be closed by this pull request
@SimplyDanny SimplyDanny merged commit a84d9a9 into realm:main Mar 8, 2024
12 checks passed
kohtenko pushed a commit to kohtenko/SwiftLint that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Request: Prefer static over final class
3 participants