Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop triggering mark rule in the middle of another comment #5593

Merged
merged 1 commit into from
May 17, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #5592.

@SwiftLintBot
Copy link

17 Messages
📖 Linting Aerial with this PR took 1.24s vs 1.25s on main (0% faster)
📖 Linting Alamofire with this PR took 1.8s vs 1.81s on main (0% faster)
📖 Linting Brave with this PR took 10.46s vs 10.47s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 5.55s vs 5.54s on main (0% slower)
📖 Linting Firefox with this PR took 13.7s vs 13.71s on main (0% faster)
📖 Linting Kickstarter with this PR took 12.67s vs 12.73s on main (0% faster)
📖 Linting Moya with this PR took 0.71s vs 0.7s on main (1% slower)
📖 Linting NetNewsWire with this PR took 3.7s vs 3.72s on main (0% faster)
📖 Linting Nimble with this PR took 1.03s vs 1.04s on main (0% faster)
📖 Linting PocketCasts with this PR took 10.4s vs 10.39s on main (0% slower)
📖 Linting Quick with this PR took 0.54s vs 0.54s on main (0% slower)
📖 Linting Realm with this PR took 6.34s vs 6.37s on main (0% faster)
📖 Linting Sourcery with this PR took 3.2s vs 3.2s on main (0% slower)
📖 Linting Swift with this PR took 6.34s vs 6.38s on main (0% faster)
📖 Linting VLC with this PR took 1.68s vs 1.69s on main (0% faster)
📖 Linting Wire with this PR took 23.82s vs 23.96s on main (0% faster)
📖 Linting WordPress with this PR took 15.88s vs 15.93s on main (0% faster)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit ebf7c70 into realm:main May 17, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the mark-rule branch May 17, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MARK Rule hitting on "marketing"
2 participants