Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw deprecation warning if deprecated property is not presented in configuration #5792

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

chipp
Copy link
Contributor

@chipp chipp commented Sep 12, 2024

Fixes #5791

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 12, 2024

17 Messages
📖 Linting Aerial with this PR took 0.94s vs 0.92s on main (2% slower)
📖 Linting Alamofire with this PR took 1.28s vs 1.3s on main (1% faster)
📖 Linting Brave with this PR took 7.49s vs 7.53s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 5.02s vs 5.04s on main (0% faster)
📖 Linting Firefox with this PR took 11.03s vs 11.05s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.11s vs 10.13s on main (0% faster)
📖 Linting Moya with this PR took 0.55s vs 0.56s on main (1% faster)
📖 Linting NetNewsWire with this PR took 2.57s vs 2.55s on main (0% slower)
📖 Linting Nimble with this PR took 0.76s vs 0.77s on main (1% faster)
📖 Linting PocketCasts with this PR took 8.76s vs 8.64s on main (1% slower)
📖 Linting Quick with this PR took 0.45s vs 0.47s on main (4% faster)
📖 Linting Realm with this PR took 4.71s vs 4.7s on main (0% slower)
📖 Linting Sourcery with this PR took 2.36s vs 2.36s on main (0% slower)
📖 Linting Swift with this PR took 4.65s vs 4.58s on main (1% slower)
📖 Linting VLC with this PR took 1.25s vs 1.26s on main (0% faster)
📖 Linting Wire with this PR took 18.35s vs 18.27s on main (0% slower)
📖 Linting WordPress with this PR took 11.82s vs 11.86s on main (0% faster)

Generated by 🚫 Danger

@chipp chipp force-pushed the main branch 2 times, most recently from c1c8b70 to 66deac9 Compare September 13, 2024 06:39
@chipp
Copy link
Contributor Author

chipp commented Sep 13, 2024

@SimplyDanny, could you check that and potentially release 0.57.1 hotfix, please? Thank you!

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few nits this looks good to me. Thanks!

Source/SwiftLintCoreMacros/RuleConfigurationMacros.swift Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@chipp chipp force-pushed the main branch 3 times, most recently from 7059f49 to c62e2ac Compare September 15, 2024 18:16
@SimplyDanny SimplyDanny merged commit 0d04196 into realm:main Sep 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having any (non-deprecated) opening_brace option in .swiftlint.yml triggers deprecation warning
3 participants