Skip to content

Conversation

@GandaLF2006
Copy link
Contributor

This PR refactors the multiline_parameters rule to:

  • Fix incorrect or incomplete handling of the max_number_of_single_line_parameters configuration
  • Simplify internal logic and improve code readability without affecting performance

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 1, 2025

18 Messages
📖 Building this branch resulted in the same binary size as when built on main.
📖 Linting Aerial with this PR took 1.04 s vs 1.05 s on main (0% faster).
📖 Linting Alamofire with this PR took 1.4 s vs 1.4 s on main (0% slower).
📖 Linting Brave with this PR took 9.74 s vs 9.75 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 25.59 s vs 25.52 s on main (0% slower).
📖 Linting Firefox with this PR took 13.58 s vs 13.57 s on main (0% slower).
📖 Linting Kickstarter with this PR took 11.16 s vs 11.11 s on main (0% slower).
📖 Linting Moya with this PR took 0.56 s vs 0.56 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 3.21 s vs 3.22 s on main (0% faster).
📖 Linting Nimble with this PR took 0.85 s vs 0.85 s on main (0% slower).
📖 Linting PocketCasts with this PR took 9.2 s vs 9.21 s on main (0% faster).
📖 Linting Quick with this PR took 0.49 s vs 0.49 s on main (0% slower).
📖 Linting Realm with this PR took 4.84 s vs 4.82 s on main (0% slower).
📖 Linting Sourcery with this PR took 2.46 s vs 2.47 s on main (0% faster).
📖 Linting Swift with this PR took 5.64 s vs 5.63 s on main (0% slower).
📖 Linting VLC with this PR took 1.48 s vs 1.49 s on main (0% faster).
📖 Linting Wire with this PR took 22.57 s vs 22.59 s on main (0% faster).
📖 Linting WordPress with this PR took 12.9 s vs 12.9 s on main (0% slower).

Generated by 🚫 Danger

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/improve_multiline_parameters branch 2 times, most recently from e08158f to 5bcc564 Compare July 1, 2025 09:52
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/improve_multiline_parameters branch from 5bcc564 to 3df5c81 Compare July 1, 2025 10:35
@GandaLF2006
Copy link
Contributor Author

@SimplyDanny
Hey. Please review PR :)

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@SimplyDanny SimplyDanny enabled auto-merge (squash) July 2, 2025 20:36
@SimplyDanny SimplyDanny merged commit 097bef2 into realm:main Jul 2, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants