-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix async_without_await false positives for override declarations #6417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SimplyDanny <16365760+SimplyDanny@users.noreply.github.com>
…await rule Co-authored-by: SimplyDanny <16365760+SimplyDanny@users.noreply.github.com>
Generated by 🚫 Danger |
Co-authored-by: SimplyDanny <16365760+SimplyDanny@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false positive triggers in SwiftLint for override functions
Fix async_without_await false positives for override declarations
Jan 6, 2026
SimplyDanny
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
async_without_awaitrule incorrectly flaggedoverridefunctions, property accessors, and initializers that don't await. These declarations must retainasyncto properly override the parent's async signature.Changes
overridemodifier presentoverrideoverridemodifier presentSyntax.closestVariableOrSubscript()helper for accessor parent lookupNote
CHANGELOG placeholder
#ISSUE_NUMBERshould be replaced with the actual issue reference.Original prompt
async_without_await,unneeded_throws_rethrowswithoverridefunctions #6416✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.