-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code not using Menlo font outside of README #137
Comments
We'd love to see a PR changing that! (With screenshots for comparison, to make seeing the before/after difference easier) |
I'm closing this as a duplicate of #95, which would fix this and more. |
@segiddins Sure! :) @jpsim Not a problem. Would you be open to taking a small patch for this in the meantime, since this is user facing? Patchdiff --git a/lib/jazzy/assets/css/jazzy.css.scss b/lib/jazzy/assets/css/jazzy.css.scss
index f4b14b4..e1c22b0 100644
--- a/lib/jazzy/assets/css/jazzy.css.scss
+++ b/lib/jazzy/assets/css/jazzy.css.scss
@@ -1,5 +1,6 @@
$doc_coverage_color: #999;
$content_wrapper_width: 980px;
+$code-font: 12px Menlo, monospace;
html, body, div, span, h1, h3, h4, p, a, code, em, img, ul, li, table, tbody, tr, td {
background: transparent;
@@ -97,6 +98,7 @@ html, body, div, span, h1, h3, h4, p, a, code, em, img, ul, li, table, tbody, tr
font-size: 1.4em;
word-break: break-all;
> code {
+ font: $code-font;
display: inline-block;
}
}
@@ -149,6 +151,7 @@ html, body, div, span, h1, h3, h4, p, a, code, em, img, ul, li, table, tbody, tr
.section .declaration {
margin-top: 21px;
code {
+ font: $code-font;
color: rgba(128, 128, 128, 1);
margin-bottom: 15px;
padding-bottom: 6px; BeforeAfterTested on Firefox & Safari. |
- Applied small patch seen here in link below to fix font for code (to Menlo) realm/jazzy#137 (comment)
- Applied small patch seen here in link below to fix font for code (to Menlo) realm/jazzy#137 (comment)
Ping! :) Only because #95 could take a while till its implemented. |
Sure, send in a PR and I'd be happy to take a look! |
Awesome! :) |
Code inside a README displays fine, uses Menlo at 12px (like Apple's own docs), but anywhere else it's monospace at 11px (which is quite illegible in comparison). Looks like
jazzy.css.scss
doesn't apply the style tocode
elsewhere.The text was updated successfully, but these errors were encountered: