Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error compiling Swift podspec in Xcode 10 #1004

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Fix error compiling Swift podspec in Xcode 10 #1004

merged 1 commit into from
Sep 24, 2018

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Sep 17, 2018

Removed the extra quotes around the SWIFT_VERSION build setting to avoid an xcodebuild error under the new build system (i.e., Xcode 10).

Fixes #970.

@1ec5 1ec5 added the bug label Sep 17, 2018
@1ec5 1ec5 self-assigned this Sep 17, 2018
@1ec5 1ec5 requested a review from johnfairh September 17, 2018 06:30
This was referenced Sep 17, 2018
Closed
Closed
Merged
@fassko fassko mentioned this pull request Sep 19, 2018
Closed
ekazaev
ekazaev approved these changes Sep 19, 2018
View reviewed changes
Copy link

@ekazaev ekazaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helped me

johnfairh
johnfairh requested changes Sep 21, 2018
View reviewed changes
Copy link
Collaborator

@johnfairh johnfairh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - playing around with Xcode versions this looks good, can you just add the double-space newline to the changelog summary line please?

@1ec5
Copy link
Collaborator Author

1ec5 commented Sep 24, 2018

can you just add the double-space newline to the changelog summary line please?

Thanks, fixed.

@fassko fassko mentioned this pull request Sep 24, 2018
Merged
@johnfairh
Copy link
Collaborator

👍

@johnfairh johnfairh merged commit 0d7c28d into master Sep 24, 2018
@johnfairh johnfairh deleted the 1ec5-podspec-xcode-10-970 branch September 24, 2018 15:34
@johnfairh johnfairh restored the 1ec5-podspec-xcode-10-970 branch September 24, 2018 15:34
@johnfairh johnfairh deleted the 1ec5-podspec-xcode-10-970 branch September 24, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekazaev ekazaev ekazaev approved these changes

@johnfairh johnfairh johnfairh approved these changes

Assignees

@1ec5 1ec5

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ec5 @johnfairh @ekazaev