Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KaTeX to render math expressions in markdown #1164

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Use KaTeX to render math expressions in markdown #1164

merged 1 commit into from
Mar 21, 2020

Conversation

johnfairh
Copy link
Collaborator

#1159 continued.

  • Bundle KaTeX only if the generated docs require it. No need for a flag.
  • Use KaTeX options to improve display style, means no need for custom css.
  • Add some docs.

Screenshot 2020-03-16 at 22 00 48

@arguiot please take a look.

@johnfairh @arguiot
Use KaTeX to render math expressions in markdown
6df29d2 
Co-authored-by: Arthur Guiot <arguiot@gmail.com>
@johnfairh johnfairh mentioned this pull request Mar 17, 2020
Closed
@arguiot
Copy link
Contributor

arguiot commented Mar 17, 2020

Alright, it looks good to me. Do I have to close my PR for the integration specs?

@johnfairh
Copy link
Collaborator Author

Let's merge this while Xcode 11.4 dawdles somewhere. Not sure what is up with the CircleCI GitHub hooks, it's all green on the other end.

@arguiot yes I couldn't really use that PR because I refactored how the files were stored in the themes. Thanks for your work on this.

@johnfairh johnfairh merged commit 5fcab19 into master Mar 21, 2020
@johnfairh johnfairh deleted the jf-katex branch March 21, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnfairh @arguiot