Escape question marks in URLs

[PaulTaykalo]

Source Kitten output could have question marks in document names when parsing Swift sources. Since we cannot use question marks in URLs, we need to escape them with some adequate characters sequence. q was added to represent question mark, and - was added since no potential function name can have dashes in it

[PaulTaykalo]

This one is the fix for #547

[jpsim]

Is there a way we could apply a more general URL sanitization step?

[PaulTaykalo]

@jpsim for example? Are there any other issues related to the URLs sanitization?

[jpsim]

Yes, there have been issues with Windows file names before too, which is why I'd like to implement a general solution to URL escaping rather than hardcoding this case, without addressing possible others.

[PaulTaykalo]

@jpsim like this one #361?
It's not technically escaping. Well, its' not URL escaping, As far as I see - valid file name without special characters should be generated. As well as valid URL. Haven't seen any library/code that will do that conversion for all OSes.
So currently there should be only these \ / : * ? " < > |
I would suggest to handle it in the same way, unless there's better option
What do you think?

So I suggest by simply adding handlign for these characters, and handle them in tests in https://github.com/realm/jazzy-integration-specs/tree/master/misc_jazzy_features

[jpsim]

That seems fine to me!

[pigeon-archive]

Since the original solution proposed in this PR was rejected in favour of a more generic one, I'm going to close this PR. Feel free to re-open or file a new PR with the new/preferred solution.