Add support for an "include" option #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickffox
changed the title
|
This implementation is used internally by our team. Opening this PR to facilitate discussion. |
johnfairh
requested changes
Mar 29, 2018
CHANGELOG.md
Outdated
| @@ -5,8 +5,11 @@ | |||
| * None. | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * None. | |||
| -------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Don't need this line, see style in the rest of the file. Could drop the 'to jazzy' part too, I think the context is clear.
lib/jazzy/sourcekitten.rb
Outdated
| included_files = Config.instance.included_files | ||
| json.map do |doc| | ||
| key = doc.keys.first | ||
| doc if included_files.detect do |foo| |
There was a problem hiding this comment.
Maybe a better variable name :-)
|
@johnfairh I've addressed your feedback and updated the README. Let me know what you think! |
johnfairh
approved these changes
Mar 29, 2018
|
LGTM - could you squash these commits please? |
* Added support for -i or -include which has the opposite behavior of the exclude flag * Updated file filtering to account for include flag * Updated README and documentation
|
@johnfairh squashed 👍 |
|
Great - thank you. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #949