Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer filesystem spelling of pathnames #967

Merged
merged 1 commit into from
May 10, 2018
Merged

Prefer filesystem spelling of pathnames #967

merged 1 commit into from
May 10, 2018

Conversation

johnfairh
Copy link
Collaborator

Fix #965 - use the filesystem spelling of paths as canonical. Tested locally with cases that would crash before.

@SDGGiesbrecht from previous bugs of mine I think you have access to a case-sensitive config, if so would you mind trying out this patch at some point just to check there's nothing broken there (should be fine...)

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but it'd be great if @SDGGiesbrecht could confirm.

@SDGGiesbrecht
Copy link
Contributor

Sure thing. Fetching now.

Is there a specific situation you want me to test?

@SDGGiesbrecht
Copy link
Contributor

Is there a specific situation you want me to test?

With an existing “Docs” directory, right?

@jpsim
Copy link
Collaborator

jpsim commented May 9, 2018

With an existing “Docs” directory, right?

Yes, since previously it would get clobbered with docs (lowercase)

@SDGGiesbrecht
Copy link
Contributor

@johnfairh, @jpsim

No crashes.

  • Without existing directory → creates docs/
  • Existing docs/ → uses it
  • Existing Docs/ → leaves it alone and creates docs/ beside it

@SDGGiesbrecht
Copy link
Contributor

Just for kicks, I successfully committed and then checked out the version with both docs/ and Docs/ present, so Git really does not care—but it makes me wonder what would happen if a case‐insensitive file system cloned and tried to check it out...

Thankfully none of that is Jazzy’s responsibility.

@johnfairh
Copy link
Collaborator Author

Great, thanks.

@johnfairh johnfairh merged commit 54fc957 into master May 10, 2018
@johnfairh johnfairh deleted the jf-sync-fsname branch May 10, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants