Update after review #1

realm · May 25, 2021 · 390e6d7 · 390e6d7
1 parent 4983f86
commit 390e6d7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 31 deletions.
diff --git a/test/object-store/results.cpp b/test/object-store/results.cpp
@@ -3248,16 +3248,6 @@ TEMPLATE_TEST_CASE("results: get<Obj>() intermixed with writes", "", ResultsFrom
 
  r->begin_transaction();
 
- /*
- * We no longer insert based on pk. Objects will always be inserted at the end.
- SECTION("front insertion") {
- for (int i = 0; i < 1000; ++i) {
- table->create_object_with_primary_key(1000 - i);
- REQUIRE(results.get<Obj>(0).get<int64_t>(col_value) == 1000 - i);
- }
- }
- */
-
  SECTION("append at end") {
  for (int i = 0; i < 1000; ++i) {
  table->create_object_with_primary_key(i);

diff --git a/test/test_global_key.cpp b/test/test_global_key.cpp
@@ -75,24 +75,3 @@ TEST(GlobalKey_Compare)
  CHECK_LESS(GlobalKey(0, 0), GlobalKey(0, 1));
  CHECK_LESS(GlobalKey(0, 0), GlobalKey(1, 0));
 }
-
-/*
-TEST(GlobalKey_PrimaryKey)
-{
- {
- GlobalKey object_id(Mixed{});
- auto oid = object_id.to_string();
- CHECK_EQUAL(oid, "{0001-0000}");
- }
- {
- GlobalKey object_id{123};
- auto oid = object_id.to_string();
- CHECK_EQUAL(oid, "{0000-007b}");
- }
- {
- GlobalKey object_id{"Exactly!"};
- auto oid = object_id.to_string();
- CHECK_EQUAL(oid, "{495f44d153789d90-d2f64663ba17c5bc}");
- }
-}
-*/