Add implementation of TableView::find_fist_binary() using the same id…

…ea as is used in TableView::find_fist_string()
realm · May 13, 2013 · ce60f6c · ce60f6c
1 parent 4090b8a
commit ce60f6c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/src/tightdb/table_view.cpp b/src/tightdb/table_view.cpp
@@ -18,15 +18,6 @@ size_t TableViewBase::find_first_integer(size_t column_ndx, int64_t value) const
     return size_t(-1);
 }
 
-size_t TableViewBase::find_first_string(size_t column_ndx, StringData value) const
-{
-    TIGHTDB_ASSERT_COLUMN_AND_TYPE(column_ndx, type_String);
-
-    for (size_t i = 0; i < m_refs.size(); i++)
-        if (get_string(column_ndx, i) == value) return i;
-    return size_t(-1);
-}
-
 size_t TableViewBase::find_first_float(size_t column_ndx, float value) const
 {
     for (size_t i = 0; i < m_refs.size(); i++)
@@ -43,6 +34,24 @@ size_t TableViewBase::find_first_double(size_t column_ndx, double value) const
     return size_t(-1);
 }
 
+size_t TableViewBase::find_first_string(size_t column_ndx, StringData value) const
+{
+    TIGHTDB_ASSERT_COLUMN_AND_TYPE(column_ndx, type_String);
+
+    for (size_t i = 0; i < m_refs.size(); i++)
+        if (get_string(column_ndx, i) == value) return i;
+    return size_t(-1);
+}
+
+size_t TableViewBase::find_first_binary(size_t column_ndx, BinaryData value) const
+{
+    TIGHTDB_ASSERT_COLUMN_AND_TYPE(column_ndx, type_Binary);
+
+    for (size_t i = 0; i < m_refs.size(); i++)
+        if (get_binary(column_ndx, i) == value) return i;
+    return size_t(-1);
+}
+
 
 // Aggregates ----------------------------------------------------
 

diff --git a/src/tightdb/table_view.hpp b/src/tightdb/table_view.hpp
@@ -65,7 +65,7 @@ class TableViewBase {
     size_t find_first_float(size_t column_ndx, float value) const;
     size_t find_first_double(size_t column_ndx, double value) const;
     size_t find_first_string(size_t column_ndx, StringData value) const;
-    // FIXME: Need: size_t find_first_binary(size_t column_ndx, BinaryData value) const;
+    size_t find_first_binary(size_t column_ndx, BinaryData value) const;
 
     // Aggregate functions
     template <int function, typename T, typename R, class ColType>